Skip to content

Python: Update change note for 1.22. #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2019
Merged

Python: Update change note for 1.22. #1817

merged 2 commits into from
Aug 25, 2019

Conversation

taus-semmle
Copy link
Contributor

@felicity-semmle for review.

@markshannon Do you see anything that needs to be added?

@markshannon
Copy link
Contributor

A couple of other things.

  • A new NegativeIntegerLiteral class has been added as a subtype of ImmutableLiteral. So -1 is treated as an ImmutableLiteral. This means that queries looking for the use of constant integers will automatically handle negative numbers.
  • Value::forInt(int x) and Value::forString(string s) have been added to make it easier to refer to the Value entities for common constants.

@felicitymay felicitymay added this to the 1.22 milestone Aug 24, 2019
@felicitymay felicitymay added the Priority PR that should be reviewed and merged as a matter of priority. label Aug 24, 2019
felicitymay
felicitymay reviewed Aug 24, 2019
View reviewed changes
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for expanding on the original change notes @taus-semmle. One very minor text suggestion, in addition to Mark's notes. Otherwise LGTM.

change-notes/1.22/analysis-python.md Outdated

### Other improvements

- Short flags for regexes (e.g. `re.M` for multiline regexes) are now handled correctly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Short flags for regexes (e.g. `re.M` for multiline regexes) are now handled correctly.
- Short flags for regexes (for example, `re.M` for multiline regexes) are now handled correctly.

felicitymay
felicitymay approved these changes Aug 25, 2019
View reviewed changes
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@semmle-qlci semmle-qlci merged commit 30921d5 into github:master Aug 25, 2019
@tausbn tausbn deleted the python-change-notes-1.22 branch February 12, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felicitymay felicitymay felicitymay approved these changes

Assignees
No one assigned
Labels
Priority PR that should be reviewed and merged as a matter of priority. Python
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@taus-semmle @markshannon @felicitymay @semmle-qlci