Skip to content

JS: Change notes for jump-to-def and documentation improvements #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2019
Merged

JS: Change notes for jump-to-def and documentation improvements #1825

merged 2 commits into from
Aug 26, 2019

Conversation

asger-semmle
Copy link
Contributor

  • Mentions jump-to-def improvements in the general section.
  • Mentioned documentation improvements in the "QL libraries" section as that's mainly of interest to QL writers.

@asger-semmle asger-semmle added this to the 1.22 milestone Aug 26, 2019
felicitymay
felicitymay reviewed Aug 26, 2019
View reviewed changes
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. One typo, but otherwise LGTM. I'll leave @xiemaisi to review and merge.

@semmle-qlci semmle-qlci merged commit f123916 into github:master Aug 26, 2019
@aliscco aliscco mentioned this pull request Sep 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felicitymay felicitymay felicitymay left review comments

+1 more reviewer

@xiemaisi xiemaisi xiemaisi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@asger-semmle @xiemaisi @felicitymay @semmle-qlci