Skip to content

Rust: Tune rust/diagnostic/database-quality #20312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2025
+6 −4
Merged

Rust: Tune rust/diagnostic/database-quality #20312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c90b90
Rust: Lower the thresholds in rust/diagnostic/database-quality to mor…
geoffw0 Aug 28, 2025
9e0a31c
Rust: Change note.
geoffw0 Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rust/ql/src/change-notes/2025-08-28-diagnostic-database-quality.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: fix
---
* The "Low Rust analysis quality" query (`rust/diagnostic/database-quality`) has been tuned so that it won't trigger on databases that have extracted normally. This will remove spurious messages of "Low Rust analysis quality" on the CodeQL status page.
6 changes: 2 additions & 4 deletions rust/ql/src/queries/telemetry/DatabaseQualityDiagnostics.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,9 @@ import codeql.util.Unit
class DbQualityDiagnostic extends Unit {
DbQualityDiagnostic() {
exists(float percentageGood |
CallTargetStatsReport::percentageOfOk(_, percentageGood)
CallTargetStatsReport::percentageOfOk(_, percentageGood) and percentageGood < 50
or
MacroCallTargetStatsReport::percentageOfOk(_, percentageGood)
|
percentageGood < 95
MacroCallTargetStatsReport::percentageOfOk(_, percentageGood) and percentageGood < 50
)
}

Expand Down