C#: Improve database quality diagnostics query. #20366
Open
+32
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
michaelnebel
force-pushed
the
csharp/improvedatabasequalitydiagnostics
branch
3 times, most recently
from
6b0657b to
cafe644
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR improves the database quality diagnostics message for C# by including specific health metrics in the diagnostic output. The enhancement provides users with concrete percentage values for call targets and expression types to help them better understand database quality issues.
Key changes:
- Enhanced diagnostic message to include specific database health metrics with percentage values
- Refactored the diagnostic creation logic to capture and display both call target and expression type statistics
- Updated expected test outputs to reflect the new message format
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| csharp/ql/src/change-notes/2025-09-04-database-diagnostics.md | Documents the enhancement to include database health metrics in diagnostic messages |
| csharp/ql/src/Telemetry/DatabaseQualityDiagnostics.ql | Refactors diagnostic logic to capture specific metrics and updates the diagnostic message format |
| csharp/ql/integration-tests/all-platforms/standalone/DatabaseQualityDiagnostics.expected | Updates expected test output to match the new diagnostic message format |
michaelnebel
force-pushed
the
csharp/improvedatabasequalitydiagnostics
branch
from
cafe644 to
02e2b65
Compare
michaelnebel
changed the title
michaelnebel
force-pushed
the
csharp/improvedatabasequalitydiagnostics
branch
from
02e2b65 to
70b3a46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.