Go: Support git_source
#20368
Draft
Go: Support git_source
#20368
+79
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for git_source type registry configurations in the Go extractor's proxy handling functionality. The change extends the existing registry proxy system to handle Git sources alongside the existing goproxy server support.
- Adds
git_sourcetype support to registry configurations - Updates proxy environment variable handling to process Git sources
- Adds comprehensive test coverage for multiple registry configurations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go/extractor/util/registryproxy.go | Adds git_source constant, refactors data structures to separate goproxy servers and Git sources, and updates environment variable handling logic |
| go/extractor/util/registryproxy_test.go | Adds new test function to verify parsing of multiple registry configurations including both git_source and goproxy_server types |
| multiple := parseRegistryConfigsSuccess(t, "[{ \"type\": \"git_source\", \"url\": \"https://github.com/github\" }, { \"type\": \"goproxy_server\", \"url\": \"https://proxy.example.com/mod\" }]") | ||
|
|
||
| if len(multiple) != 2 { | ||
| t.Fatalf("Expected `parseRegistryConfigs` to return two configuration, but got %d.", len(multiple)) |
There was a problem hiding this comment.
The error message contains a grammatical error. 'two configuration' should be 'two configurations'.
Suggested change
| t.Fatalf("Expected `parseRegistryConfigs` to return two configuration, but got %d.", len(multiple)) | |
| t.Fatalf("Expected `parseRegistryConfigs` to return two configurations, but got %d.", len(multiple)) |
Copilot uses AI. Check for mistakes.
mbg
force-pushed
the
mbg/go/support-git-source
branch
2 times, most recently
from
6576e3b to
35ff9fd
Compare
Since `GOPRIVATE` / `GONOPROXY` expect a glob pattern
mbg
force-pushed
the
mbg/go/support-git-source
branch
from
35ff9fd to
cb7a155
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.