Shared: Use sourceBoundedFastTC in TypeTracking
#20370
Open
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
force-pushed
the
source-bounded-fast-tc-in-typetracking
branch
from
09ff926 to
efa5766
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the TypeTracking implementation by using sourceBoundedFastTC for transitive closure computation instead of manual recursion. The change aims to reduce high iteration counts observed in C/C++ projects by leveraging a Higher-Order Predicate (HOP) for better performance.
Key Changes
- Replaced manual recursion in
standardFlowsTowithsourceBoundedFastTCtransitive closure - Introduced
simpleLocalSmallStepPluspredicate using the optimized transitive closure - Modified
isLocalSourceNodepredicate to support the new approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen quite high iteration counts for this predicate in C/C++ on some projects. I don't see why we shouldn't use a HOP here 🤷
In particular, this significantly reduces the analysis time on https://github.com/openvinotoolkit/oneDNN when running with
--ram=6000(which we saw in the 2.23.0 upgrade)