Skip to content

Actions: Add file coverage information for status page #20371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 8, 2025
Merged

Actions: Add file coverage information for status page #20371

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
67dc01b
Actions: Add successfully extracted files query
henrymercer Aug 29, 2025
71bac5e
Actions: Add file coverage baseline
henrymercer Aug 29, 2025
a6fb45b
Update expected files
henrymercer Sep 5, 2025
e7fbd28
Add changelog note
henrymercer Sep 5, 2025
526990e
Add comment about GitHub API languages
henrymercer Sep 5, 2025
fea0533
Add date to changelog note filename
henrymercer Sep 5, 2025
1e77891
Merge branch 'main' into henrymercer/actions-status
henrymercer Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion actions/extractor/codeql-extractor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ build_modes:
- none
file_coverage_languages: []
github_api_languages: []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth putting a comment here that actions isn't its own language as far as linguist/the API is concerned and therefore not listed?

scc_languages: []
scc_languages:
- YAML
Comment on lines +13 to +14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that this is now consistent with other languages. What effect does adding this have?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tells scc to pick up files marked as YAML when CodeQL scans for the baseline set of files. These are then further filtered down by the configure baseline script.

file_types:
- name: workflow
display_name: GitHub Actions workflow files
Expand Down
10 changes: 10 additions & 0 deletions actions/extractor/tools/baseline-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"paths": [
".github/workflows/*.yml",
".github/workflows/*.yaml",
".github/reusable_workflows/**/*.yml",
".github/reusable_workflows/**/*.yaml",
"**/action.yml",
"**/action.yaml"
]
}
2 changes: 2 additions & 0 deletions actions/extractor/tools/configure-baseline.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
@echo off
type "%CODEQL_EXTRACTOR_ACTIONS_ROOT%\tools\baseline-config.json"
3 changes: 3 additions & 0 deletions actions/extractor/tools/configure-baseline.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/bin/sh

cat "$CODEQL_EXTRACTOR_ACTIONS_ROOT/tools/baseline-config.json"
1 change: 1 addition & 0 deletions actions/ql/integration-tests/query-suite/actions-code-scanning.qls.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
ql/actions/ql/src/Diagnostics/SuccessfullyExtractedFiles.ql
ql/actions/ql/src/Security/CWE-077/EnvPathInjectionCritical.ql
ql/actions/ql/src/Security/CWE-077/EnvVarInjectionCritical.ql
ql/actions/ql/src/Security/CWE-094/CodeInjectionCritical.ql
Expand Down
1 change: 1 addition & 0 deletions actions/ql/integration-tests/query-suite/actions-security-and-quality.qls.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
ql/actions/ql/src/Debug/SyntaxError.ql
ql/actions/ql/src/Diagnostics/SuccessfullyExtractedFiles.ql
ql/actions/ql/src/Security/CWE-077/EnvPathInjectionCritical.ql
ql/actions/ql/src/Security/CWE-077/EnvPathInjectionMedium.ql
ql/actions/ql/src/Security/CWE-077/EnvVarInjectionCritical.ql
Expand Down
1 change: 1 addition & 0 deletions actions/ql/integration-tests/query-suite/actions-security-extended.qls.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
ql/actions/ql/src/Diagnostics/SuccessfullyExtractedFiles.ql
ql/actions/ql/src/Security/CWE-077/EnvPathInjectionCritical.ql
ql/actions/ql/src/Security/CWE-077/EnvPathInjectionMedium.ql
ql/actions/ql/src/Security/CWE-077/EnvVarInjectionCritical.ql
Expand Down
13 changes: 13 additions & 0 deletions actions/ql/src/Diagnostics/SuccessfullyExtractedFiles.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/**
* @id actions/diagnostics/successfully-extracted-files
* @name Extracted files
* @description List all files that were extracted.
* @kind diagnostic
* @tags successfully-extracted-files
*/

private import codeql.Locations

from File f
where exists(f.getRelativePath())
select f, ""
Comment on lines +11 to +13

Check warning

Code scanning / CodeQL

Consistent alert message Warning

The actions/diagnostics/successfully-extracted-files query does not have the same alert message as cpp, rust, swift.
Loading