Skip to content

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Sep 8, 2025

The DCA experiment (__3) is a bit messy, but doesn't give me reason for concern.

@jketema jketema marked this pull request as ready for review September 9, 2025 08:15
@jketema jketema requested a review from a team as a code owner September 9, 2025 08:15
@Copilot Copilot AI review requested due to automatic review settings September 9, 2025 08:15
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Swift toolchain from an earlier version to Swift 6.1.3, including both the prebuilt binaries and resource directories for macOS and Linux platforms.

  • Updated Swift prebuilt binaries and resource directories for both macOS and Linux
  • Added change notes documenting the Swift 6.1.3 update
  • Updated binary checksums and file sizes to reflect the new Swift version

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
swift/third_party/resources/swift-prebuilt-macos.tar.zst Updated macOS Swift prebuilt binary with new checksum and size
swift/third_party/resources/swift-prebuilt-linux.tar.zst Updated Linux Swift prebuilt binary with new checksum and size
swift/third_party/resources/resource-dir-macos.zip Updated macOS resource directory with new checksum and size
swift/third_party/resources/resource-dir-linux.zip Updated Linux resource directory with new checksum and size
swift/ql/lib/change-notes/2025-09-08-swift-6.1.3.md Added change notes documenting the Swift 6.1.3 update

@geoffw0
Copy link
Contributor

geoffw0 commented Sep 9, 2025

Yep, 4/15 projects failing to build is concerning, though the errors are in the "before" runs as much as the "after" so very likely unrelated to these changes. I see that runs 1 and 2 are worse. Do you have any idea what's going on?

@jketema
Copy link
Contributor Author

jketema commented Sep 9, 2025

For MovieSwiftUI, bark, and Tofu it seems to the connection to the runner was lost. This seems to happen quite a lot nowadays, also integration tests. This looks like an infrastructure problem.

For Swiftmazing it looks like the the used version of xcodegen is no longer compatible with the XCode 14 we're targeting, and XCode 15 is not (and cannot be) installed on the macOS 13 runners we're using.

@jketema
Copy link
Contributor Author

jketema commented Sep 9, 2025

You want to ignore the DCA runs marked __1 and __2 that's me messing with some local DCA changes.

@geoffw0
Copy link
Contributor

geoffw0 commented Sep 9, 2025

For Swiftmazing it looks like the the used version of xcodegen is no longer compatible with the XCode 14 we're targeting, and XCode 15 is not (and cannot be) installed on the macOS 13 runners we're using.

So this needs fixing in the DCA config somehow? Let me know if I can help with that.

@jketema
Copy link
Contributor Author

jketema commented Sep 9, 2025

So this needs fixing in the DCA config somehow? Let me know if I can help with that.

Yes, I opened an internal issue for this.

@jketema jketema merged commit 174f89f into github:main Sep 9, 2025
18 checks passed
@jketema jketema deleted the swift-6.1.3 branch September 9, 2025 15:06
@geoffw0
Copy link
Contributor

geoffw0 commented Sep 9, 2025

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants