Rust: Infer certain type information for struct expressions #20403
Conversation
paldepind
force-pushed
the
rust/certain-struct-expr
branch
from
3da56ad to
eea7006
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds type inference for struct expressions in Rust's type inference system. The changes improve the certainty of type information for struct expressions by allowing the system to infer types directly from struct constructors.
Key changes:
- Added type inference capability for struct expressions that resolves types from their paths
- Enhanced struct expression handling to provide type arguments from inferred types
- Updated test expectations to reflect improved certainty levels for struct-related type inference
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/test/library-tests/type-inference/type-inference.expected | Test expectation updates reflecting removed type information entries for struct expressions |
| rust/ql/test/library-tests/type-inference/pattern_matching.rs | Test comment updates changing from type= to certainType= annotations for variables |
| rust/ql/test/library-tests/type-inference/main.rs | Test comment updates changing from type= to certainType= annotations for struct-related variables |
| rust/ql/lib/codeql/rust/internal/TypeInference.qll | Core implementation adding struct expression type inference functionality |
| exists(TypePath suffix | | ||
| suffix.isCons(TTypeParamTypeParameter(apos.asTypeParam()), path) and | ||
| result = CertainTypeInference::inferCertainType(this, suffix) | ||
| ) |
There was a problem hiding this comment.
Implementing this should prune some predicates thanks to the not exists(getTypeArgument(a, target, tp, _)) checks in the shared library. Using inferCertainType will include both explicit types in the path to the struct as well as other certain ways to infer the type parameter.
| | dereference.rs:122:23:122:29 | &... | &T.&T | dereference.rs:99:5:100:21 | Key | | ||
| | dereference.rs:122:24:122:29 | Key {...} | | dereference.rs:99:5:100:21 | Key | | ||
| | dereference.rs:122:24:122:29 | Key {...} | | file://:0:0:0:0 | & | | ||
| | dereference.rs:122:24:122:29 | Key {...} | &T | dereference.rs:99:5:100:21 | Key | |
There was a problem hiding this comment.
These and the removed types below are spurious, so this is an improvement.
Yes, that makes sense. I've done that and kicked off another DCA run. |
Adds certain type information for struct expressions.
DCA seems fine.