Skip to content

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Sep 12, 2025

This can only be a minor change (or something similar) to stay within the semantic versioning contraints. This is because only the patch version of the Go ql library pack was bumped during the release. Since there were no new language features in Go 1.25, this might also be the most accurate choice here.

@jketema jketema requested a review from a team as a code owner September 12, 2025 09:08
@Copilot Copilot AI review requested due to automatic review settings September 12, 2025 09:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Go library's change log documentation to mention support for Go 1.25. The change adds a "Minor Analysis Improvements" section noting Go 1.25 support, replacing the previous "No user-facing changes" entries.

  • Added Go 1.25 support announcement to change log entries
  • Replaced placeholder "No user-facing changes" text with meaningful content

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
go/ql/lib/change-notes/released/4.3.2.md Added Go 1.25 support note under Minor Analysis Improvements
go/ql/lib/CHANGELOG.md Updated version 4.3.2 section to include Go 1.25 support announcement

This can only be a minor change (or something similar) to stay within the
semantic versioning contraints. This is because only the patch version of
the Go ql library pack was bumped during the release. Since there were no new
language features in Go 1.25, this might also be the most accurate choice here.
Copy link
Member

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Minor Analysis" is what we'd usually choose, unless the version upgrade results in some breaking change.

@jketema
Copy link
Contributor Author

jketema commented Sep 12, 2025

I think "Minor Analysis" is what we'd usually choose, unless the version upgrade results in some breaking change.

I just looked at the 1.24 change note, and that had a "major".

@jketema jketema merged commit 7c35835 into github:main Sep 12, 2025
14 checks passed
@jketema jketema deleted the go-log branch September 12, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants