Skip to content

Conversation

ArinGhazarian
Copy link
Contributor

Fixes #864

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

Description

This PR adds --no-ssl-verify option to migrate-repo and generate-script commands for bbs2gh to support migrating form servers that use self-singed SSL certificates.

@ArinGhazarian ArinGhazarian changed the title Add no ssh verify to bbs2gh Add --no-ssl-verify to bbs2gh commands Mar 10, 2023
Copy link
Collaborator

@synthead synthead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Think we could add a warning to the log output about skipping SSL?

For what it's worth, a lot of companies roll their own internal CA, and as long as the CA's chain of trust is present in the user's trusted certificates, the server certificate should validate. Self-signed CAs will also cause SSL validation issues, but these are not as common for most companies that I've witnessed 🙂

@ArinGhazarian
Copy link
Contributor Author

Looks great! Think we could add a warning to the log output about skipping SSL?

For what it's worth, a lot of companies roll their own internal CA, and as long as the CA's chain of trust is present in the user's trusted certificates, the server certificate should validate. Self-signed CAs will also cause SSL validation issues, but these are not as common for most companies that I've witnessed 🙂

Not a bad idea, but since gei doesn't spit out a warning I guess for consistency bbs2gh needs to do the same.I guess ppl who use this flag know the risks too.

@github-actions
Copy link

github-actions bot commented Mar 10, 2023

Integration Test Results

8 tests  ±0   8 ✔️ ±0   24m 46s ⏱️ + 2m 50s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 8551207. ± Comparison against base commit 9bbd350.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 10, 2023

Unit Test Results

677 tests   677 ✔️  22s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 8551207.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
gei 85% 80% 633
bbs2gh 81% 76% 598
Octoshift 86% 71% 1063
ado2gh 84% 78% 674
Summary 84% (6302 / 7464) 76% (1587 / 2100) 2968

@ArinGhazarian ArinGhazarian merged commit d1ea833 into main Mar 11, 2023
@ArinGhazarian ArinGhazarian deleted the add-no-ssh-verify-to-bbs2gh branch March 11, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for --no-ssl-verify for gh bbs2gh migrate-repo
3 participants