-
Notifications
You must be signed in to change notification settings - Fork 119
Add --no-ssl-verify to bbs2gh commands #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Think we could add a warning to the log output about skipping SSL?
For what it's worth, a lot of companies roll their own internal CA, and as long as the CA's chain of trust is present in the user's trusted certificates, the server certificate should validate. Self-signed CAs will also cause SSL validation issues, but these are not as common for most companies that I've witnessed 🙂
Not a bad idea, but since |
Fixes #864
ThirdPartyNotices.txt
(if applicable)Description
This PR adds
--no-ssl-verify
option tomigrate-repo
andgenerate-script
commands forbbs2gh
to support migrating form servers that use self-singed SSL certificates.