Skip to content

Fix successive failures error in streamer #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2024
Merged

Fix successive failures error in streamer #1371

merged 1 commit into from
Jan 23, 2024

Conversation

timvaillancourt
Copy link
Collaborator

Related issue: #1370

Description

This PR fixes a conditional in go/logic/streamer.go so the specified max retries is respected

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

@timvaillancourt timvaillancourt requested a review from a user January 22, 2024 23:28
@timvaillancourt timvaillancourt added this to the v1.1.7 milestone Jan 22, 2024
@timvaillancourt timvaillancourt linked an issue Jan 22, 2024 that may be closed by this pull request
Incorrect max retries in streamer #1370
Closed
@timvaillancourt timvaillancourt merged commit 11d66d8 into github:master Jan 23, 2024
@timvaillancourt timvaillancourt deleted the fix-streamer-maxRetries-err branch January 23, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meiji163 meiji163 meiji163 approved these changes

@rashiq rashiq Awaiting requested review from rashiq rashiq is a code owner

Assignees
No one assigned
Labels
bug low-risk
Projects
None yet
Milestone
v1.1.7
Development

Successfully merging this pull request may close these issues.

Incorrect max retries in streamer
2 participants
@timvaillancourt @meiji163