interpolateParams=true: client side prepared statements #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlomi-noach
temporarily deployed
to
production/mysql_role=ghost_testing
arthurnn
reviewed
Jul 25, 2017
| @@ -56,5 +56,5 @@ func (this *ConnectionConfig) GetDBUri(databaseName string) string { | |||
| // Wrap IPv6 literals in square brackets | |||
| hostname = fmt.Sprintf("[%s]", hostname) | |||
| } | |||
| return fmt.Sprintf("%s:%s@tcp(%s:%d)/%s?charset=utf8mb4,utf8,latin1", this.User, this.Password, hostname, this.Key.Port, databaseName) | |||
There was a problem hiding this comment.
Do we want to add unit tests to the db uri method?
There was a problem hiding this comment.
@arthurnn do you have something in mind? I'm happy for any and every test addition.
There was a problem hiding this comment.
Let's merge that, I can work on these tests in a separate PR.
There was a problem hiding this comment.
This will only be merged after a few exhaustive days of testing in production (which is happening right now 😄 ).
|
This is being tested for |
|
ok, tested for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storyline: #454
In an attempt to speed up applying of binlog events, this is a low hanging fruit: set
interpolateParams=true(doc)This will set client-side prepared statements. The benefit to that is reduced round trips to the MySQL server: only one per query instead of three per query.