initial work on sql query building #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cenkore
pushed a commit
to cenkore/gh-ost
that referenced
this pull request
Feb 23, 2021
…_error handle driver timeout error
RainbowDashy
added a commit
to RainbowDashy/gh-ost
that referenced
this pull request
Jun 30, 2022
* feat: change logger fatal to panic * fix: address comment * fix: comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stuff like range-query building, equality building, ...
Did you know, for example, that this query is suboptimal in MySQL?
And we need to rewrite it as:
Now how about
(a,b)<=(3,4)? This is much worse.Such fun stuff.