Skip to content

Conversation

Rroqheo
Copy link

@Rroqheo Rroqheo commented Sep 21, 2025

Closes:

@Rroqheo Rroqheo requested a review from a team as a code owner September 21, 2025 06:06
@Copilot Copilot AI review requested due to automatic review settings September 21, 2025 06:06
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds conditional content handling to the handleFailedJobLogs function, implementing a new code path that returns structured resource content when the returnContent flag is true. The change allows the function to provide job logs as embedded resources with JSON MIME type instead of plain text.

  • Added conditional logic to return structured content with embedded resources
  • Implemented JSON marshaling and resource creation for failed job logs
  • Created URIs for individual job log resources

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +690 to +691
// return mcp.NewToolResultResource("failed job logs", , nil

Copy link
Preview

Copilot AI Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete commented code should be removed. This appears to be leftover development code that wasn't cleaned up.

Suggested change
// return mcp.NewToolResultResource("failed job logs", , nil

Copilot uses AI. Check for mistakes.

@Gowza68
Copy link

Gowza68 commented Sep 21, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants