-
Notifications
You must be signed in to change notification settings - Fork 2.6k
问我 #1107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
问我 #1107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds conditional content handling to the handleFailedJobLogs
function, implementing a new code path that returns structured resource content when the returnContent
flag is true. The change allows the function to provide job logs as embedded resources with JSON MIME type instead of plain text.
- Added conditional logic to return structured content with embedded resources
- Implemented JSON marshaling and resource creation for failed job logs
- Created URIs for individual job log resources
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
// return mcp.NewToolResultResource("failed job logs", , nil | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incomplete commented code should be removed. This appears to be leftover development code that wasn't cleaned up.
// return mcp.NewToolResultResource("failed job logs", , nil |
Copilot uses AI. Check for mistakes.
- Copilot suggests changes to a pull request for conditional content
handling.
- Josué Alejandro Marquez Oropeza approved the pull request.
***@***.***
…On Mon, 22 Sept 2025, 12:09 am Josué Alejandro Marquez Oropeza, < ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#1107 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3H3VBOAB4W7NPSZF7XVDX33T2WRFAVCNFSM6AAAAACHCK4NACVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENJQGAZTSMRQGQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Closes: