Download and process analyses results #1089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
reviewed
Jan 20, 2022
extensions/ql-vscode/src/remote-queries/analyses-results-manager.ts
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/src/remote-queries/analyses-results-manager.ts
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/src/remote-queries/analyses-results-manager.ts
Outdated
Show resolved
Hide resolved
aeisenberg
reviewed
Jan 21, 2022
There was a problem hiding this comment.
Looks good. A small suggestion about updating an error message. I'm not entirely happy with what I have, but we should be using the terms alert and path queries instead of problem or problem-path.
See https://codeql.github.com/docs/writing-codeql-queries/about-codeql-queries/#overview
After this change, I think it will be good.
extensions/ql-vscode/src/remote-queries/analyses-results-manager.ts
Outdated
Show resolved
Hide resolved
…er.ts Co-authored-by: Andrew Eisenberg <[email protected]>
aeisenberg
approved these changes
Jan 24, 2022
aeisenberg
added a commit
that referenced
this pull request
Feb 22, 2022
Remote query items will be stored in query history and will remain available across restarts. When the extension is restarted, any `InProgress` remote queries will be monitored until they complete. When clicked on, a remote query is opened and its results can be downloaded. The query text and the query file can be opened from the history menu. A remote query can be deleted as well, which will purge all results from global storage. Limitations: 1. Labels are not editable 2. Running multiple queries that each run on the same repository will have conflicting results and there will be errors when trying to view the results of the second query. This limitation is not new, but it is easier to hit now. See #1089. Both of these limitations will be addressed in future PRs.
1 task
aeisenberg
added a commit
that referenced
this pull request
Feb 22, 2022
Remote query items will be stored in query history and will remain available across restarts. When the extension is restarted, any `InProgress` remote queries will be monitored until they complete. When clicked on, a remote query is opened and its results can be downloaded. The query text and the query file can be opened from the history menu. A remote query can be deleted as well, which will purge all results from global storage. Limitations: 1. Labels are not editable 2. Running multiple queries that each run on the same repository will have conflicting results and there will be errors when trying to view the results of the second query. This limitation is not new, but it is easier to hit now. See #1089. Both of these limitations will be addressed in future PRs.
aeisenberg
added a commit
that referenced
this pull request
Feb 22, 2022
Remote query items will be stored in query history and will remain available across restarts. When the extension is restarted, any `InProgress` remote queries will be monitored until they complete. When clicked on, a remote query is opened and its results can be downloaded. The query text and the query file can be opened from the history menu. A remote query can be deleted as well, which will purge all results from global storage. Limitations: 1. Labels are not editable 2. Running multiple queries that each run on the same repository will have conflicting results and there will be errors when trying to view the results of the second query. This limitation is not new, but it is easier to hit now. See #1089. Both of these limitations will be addressed in future PRs.
aeisenberg
added a commit
that referenced
this pull request
Feb 22, 2022
Removes the limitation specified in #1089 where analyses for the same repo and different queries will overwrite each other.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic to download analyses results, do some minimal processing and make them available to the web view.
Note that this solution doesn't work well with running multiple queries but I'm hoping to address that once we have some notion of query history.
Also it does not support bqrs files as there is some Product/UX work that needs to happen.
Checklist
N/A:
ready-for-doc-reviewlabel there.