Relax CLI version constraint to allow minor version increases #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcreedcmu
commented
Feb 27, 2020
| isVersionCompatible: (v: Version) => { | ||
| return v.majorVersion === 2 && v.minorVersion === 0 | ||
| return v.majorVersion === 2 && v.minorVersion >= 0 |
There was a problem hiding this comment.
Just leaving the trivial >=0 in in case we want to require a certain minor version in the future.
jcreedcmu
force-pushed
the
jcreed/version-filter
branch
from
9c40304 to
585b694
Compare
hmakholm
approved these changes
Feb 28, 2020
This was referenced Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes to UI.
Fixes #253.