Display timeout warning and display canceled queries #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add the message to the log. Closes github#251
|
This pull request introduces 1 alert when merging 46fddfd into 35f619e - view on LGTM.com new alerts:
|
This change converts a cancelled query into a synthetic query result that is displayed in query history. Also includes some light refactoring. Closes github#250.
jcreedcmu
previously approved these changes
Mar 9, 2020
|
Oops, don't believe this approval yet, I clicked in the wrong tab. |
jcreedcmu
reviewed
Mar 9, 2020
jcreedcmu
reviewed
Mar 9, 2020
| query, | ||
| result: { | ||
| evaluationTime: 0, | ||
| resultType: messages.QueryResultType.CANCELLATION, |
There was a problem hiding this comment.
I think you want resultType to be a parameter of createSyntheticResult? This should still be messages.QueryResultType.OTHER_ERROR if we arrive here from the non-cancellation fallthrough (your diff's line 472).
jcreedcmu
reviewed
Mar 9, 2020
aeisenberg
added a commit
to aeisenberg/vscode-codeql
that referenced
this pull request
Mar 9, 2020
Converts a namespace into an enum.
jcreedcmu
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Display queries that are canceled during compilation
This change converts a cancelled query into a synthetic query result
that is displayed in query history.
Also includes some light refactoring.
fix: Display message when query times out
Also, add the message to the log.
Closes #250
Closes #251