Manage User Badges in the UI #31262

HenriquerPimentel · 2024-06-05T14:08:21Z

Implemented #29798

This feature implements:

List all badges
Create new badges
View badge
Edit badge
Add user to badge

Implemented Badge Management in administration panel

Updated badge model (models/user/badge.go)
Added new type of errors ErrBadgeAlreadyExist and ErrBadgeNotExist (models/user/error.go)
Implemented badge service methods (services/user/badge.go)
Implemented new type of form AdminCreateBadgeForm (services/forms/admin.go)
Implemented new binding rules to check if ImageURL is valid and if is Slug Pattern (modules/validation/binding.go) (modules/web/middleware.go) (modules/validation/helpers.go)
Implemented badge search (routers/web/explore/badge.go) (routers/web/admin/badges.go)
Implemented badges routing (routers/web/web.go)
Implemented templates for create/list/edit/view badges (templates/admin/badge/*) (templates/admin/navbar.tmpl)
9 Added new translation phrases (en-US): search.badge_kind, form.ImageURL, form.invalid_image_url_error, form.slug_been_taken, admin.badges, admin.badges.badges_manage_panel, admin.badges.details, admin.badges.new_badge, admin.badges.slug, admin.badges.description, admin.badges.image_url, admin.badges.slug.must_fill, admin.badges.new_success, admin.badges.update_success, admin.badges.deletion_success, admin.badges.edit_badge, admin.badges.update_badge, admin.badges.delete_badge, admin.badges.delete_badge_desc

Implemented User Badge Management Interface

Implemented rule to verify if a user badge already exists before insert (models/user/badge.go).
Implemented interface to manage user badge, within administration panel. (routers/web/web.go) (routers/web/explore/badge.go) (routers/web/admin/badges.go) (templates/admin/badge/users.tmpl).
Small bug fixes (view.tmpl, list.tmpl)
Added new translation phrases: admin.badges.users_with_badge, admin.badges.add_user, admin.badges.remove_user, admin.badges.delete_user_desc, admin.badges.not_found, admin.badges.user_add_success, admin.badges.user_remove_success, admin.badges.manage_users.

techknowlogick

Thanks for the PR! The CI has a few linting reports that came up that I've reported in line :)

templates/admin/badge/users.tmpl

HenriquerPimentel · 2024-06-17T21:31:01Z

Thanks for the PR! The CI has a few linting reports that came up that I've reported in line :)

Thank you so much!

Co-authored-by: Diogo Vicente <[email protected]>

routers/web/admin/badges.go

techknowlogick · 2024-06-19T15:34:13Z

@HenriquerPimentel looks like some different CI steps are failing, also related to linting (some public go functions require comments to document their purpose, eg AdminCreateBadge), although with AdminCreateBadge as it is a wrapper for another function without any transformative properties or checks that one could probably be kept as just CreateBadge without the secondary function.

As a sidenote: force pushing erases some review history as GitHub sees some files as new (even if they remain the same). If you could reduce your force pushes, it'd be helpful to me as a reviewer so I can keep track of what I've seen already
disclaimer: most of the time we try to discourage force pushing to PRs for this reason, although depending on the reviewer of a certain PR they can "call an audible" depending on the situation and might be ok with it.

models/user/badge.go

wxiaoguang · 2025-08-19T03:27:19Z

options/locale/locale_en-US.ini

@@ -603,12 +605,15 @@ unknown_error = Unknown error:
 captcha_incorrect = The CAPTCHA code is incorrect.
 password_not_match = The passwords do not match.
 lang_select_error = Select a language from the list.
+invalid_image_url_error = `Please provide a valid image URL.`
+invalid_slug_error = `Please provide a valid slug.`


Crowdin doesn't work with back-quote

wxiaoguang · 2025-08-19T03:28:54Z

routers/web/admin/badges.go

+			switch {
+			default:
+				ctx.ServerError("UpdateBadge", err)
+			}


only switch-default?

(many places)

wxiaoguang · 2025-08-19T03:29:39Z

routers/web/admin/badges.go

+	b.ImageURL = form.ImageURL
+	b.Description = form.Description
+
+	if err := user_model.UpdateBadge(ctx, ctx.Data["Badge"].(*user_model.Badge)); err != nil {


Why it uses dynamic type here ctx.Data["Badge"].(*user_model.Badge))? There should be a static typed variable "badge"

wxiaoguang · 2025-08-19T03:30:37Z

routers/web/admin/badges.go

+	page := ctx.FormInt("page")
+	if page <= 0 {
+		page = 1
+	}


09b4e68 It should use max.

wxiaoguang · 2025-08-19T03:31:35Z

routers/web/admin/badges.go

+		if user_model.IsErrBadgeNotExist(err) {
+			ctx.Flash.Error(ctx.Tr("admin.badges.not_found"))
+		} else {
+			ctx.ServerError("AddUserBadge", err)
+		}
+		return


ctx.Flash.Error + return is wrong

(many places)

wxiaoguang · 2025-08-19T03:33:00Z

routers/web/admin/badges.go

+func RenderBadgeSearch(ctx *context.Context, opts *user_model.SearchBadgeOptions, tplName templates.TplName) {
+	// Sitemap index for sitemap paths
+	opts.Page = int(ctx.PathParamInt64("idx"))


Why "sitemap" in the "admin" routes?

wxiaoguang · 2025-08-19T03:35:15Z

services/forms/admin.go

+type AdminCreateBadgeForm struct {
+	Slug        string `binding:"Required;Slug"`
+	Description string `binding:"Required"`
+	ImageURL    string `binding:"ValidImageUrl"`


What is ValidImageUrl?

…querPimentel-Badge

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 5, 2024

pull-request-size bot added the size/XXL label Jun 5, 2024

github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jun 5, 2024

HenriquerPimentel marked this pull request as draft June 5, 2024 14:10

HenriquerPimentel force-pushed the Badge branch from 9983632 to 91b085b Compare June 5, 2024 16:18

HenriquerPimentel force-pushed the Badge branch from 91b085b to 9bd77fd Compare June 14, 2024 11:59

HenriquerPimentel marked this pull request as ready for review June 14, 2024 12:00

HenriquerPimentel force-pushed the Badge branch from 9bd77fd to 5cc1147 Compare June 14, 2024 12:00

lunny added this to the 1.23.0 milestone Jun 14, 2024

techknowlogick reviewed Jun 14, 2024

View reviewed changes

templates/admin/badge/users.tmpl Show resolved Hide resolved

templates/admin/badge/users.tmpl Outdated Show resolved Hide resolved

HenriquerPimentel force-pushed the Badge branch from 5cc1147 to f378b9b Compare June 17, 2024 21:28

HenriquerPimentel force-pushed the Badge branch from 3f64e40 to 5cbed8a Compare June 18, 2024 23:42

HenriquerPimentel requested a review from techknowlogick June 18, 2024 23:42

HenriquerPimentel and others added 3 commits June 19, 2024 13:53

Implemented Badge Management in administration panel (go-gitea#29798)

8b86c31

Co-authored-by: Diogo Vicente <[email protected]>

Implemented User Badge Management Interface (go-gitea#29798)

f68e44d

Co-authored-by: Diogo Vicente <[email protected]>

Fix linting recommendations

d681313

HenriquerPimentel force-pushed the Badge branch from 5cbed8a to d681313 Compare June 19, 2024 12:53

techknowlogick reviewed Jun 19, 2024

View reviewed changes

routers/web/admin/badges.go Outdated Show resolved Hide resolved

techknowlogick added 2 commits September 7, 2024 18:09

Merge branch 'main' into Badge

10463ec

fix lints

52bc49d

pull-request-size bot added size/XL and removed size/XXL labels Sep 8, 2024

lunny reviewed Sep 26, 2024

View reviewed changes

models/user/badge.go Outdated Show resolved Hide resolved

lunny reviewed Sep 26, 2024

View reviewed changes

models/user/badge.go Outdated Show resolved Hide resolved

lunny reviewed Sep 26, 2024

View reviewed changes

models/user/badge.go Outdated Show resolved Hide resolved

Merge branch 'main' into Badge

401d257

techknowlogick requested a review from lunny August 18, 2025 18:54

fix lint

9a80816

lunny approved these changes Aug 18, 2025

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 18, 2025

wxiaoguang reviewed Aug 19, 2025

View reviewed changes

wxiaoguang mentioned this pull request Aug 28, 2025

Move HasWiki to repository service package #33912

Merged

lunny added 2 commits September 13, 2025 21:34

Merge branch 'Badge' of github.com:HenriquerPimentel/gitea into Henri…

1ecc4bb

…querPimentel-Badge

fix test

f67cc76

github-actions bot added topic/code-linting modifies/api This PR adds API routes or modifies them modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/docs modifies/internal modifies/dependencies modifies/frontend labels Sep 14, 2025

improvements

09b4e68

github-actions bot removed topic/code-linting modifies/api This PR adds API routes or modifies them modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/docs modifies/internal modifies/dependencies modifies/frontend labels Sep 15, 2025

Uh oh!

Manage User Badges in the UI #31262

Are you sure you want to change the base?

Manage User Badges in the UI #31262

Conversation

HenriquerPimentel commented Jun 5, 2024

Uh oh!

techknowlogick left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

HenriquerPimentel commented Jun 17, 2024

Uh oh!

Uh oh!

techknowlogick commented Jun 19, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wxiaoguang Aug 19, 2025 •

edited

Loading

wxiaoguang Aug 19, 2025 •

edited

Loading

wxiaoguang Aug 19, 2025 •

edited

Loading