Skip to content

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Apr 25, 2022

Add test cases for these three different scenarios to ensure that Replication functions correctly after Deployment Security Policy is enabled

Signed-off-by: Yang Jiao [email protected]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #16714

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Add test cases for these three different scenarios to ensure that Replication functions correctly after Deployment Security Policy is enabled

Signed-off-by: Yang Jiao <[email protected]>
@YangJiao0817 YangJiao0817 added area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc... labels Apr 25, 2022
@YangJiao0817 YangJiao0817 self-assigned this Apr 25, 2022
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #16738 (595b7bd) into release-2.5.0 (3d0643d) will increase coverage by 4.36%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.5.0   #16738      +/-   ##
=================================================
+ Coverage          67.39%   71.76%   +4.36%     
=================================================
  Files                949      719     -230     
  Lines              78863    66706   -12157     
  Branches            2331        0    -2331     
=================================================
- Hits               53151    47869    -5282     
+ Misses             22151    15566    -6585     
+ Partials            3561     3271     -290     
Flag Coverage Δ
unittests 71.76% <ø> (+4.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../projects/statictics/statistics-panel.component.ts
...r/new-scanner-modal/new-scanner-modal.component.ts
...ting-resolvers/project-routing-resolver.service.ts
...-confirmation-dialog/confirmation-state-message.ts
...-robot-accounts/system-robot-accounts.component.ts
...rc/app/base/harbor-shell/harbor-shell.component.ts
...s/label/label-signpost/label-signpost.component.ts
.../base/project/p2p-provider/p2p-provider.service.ts
...integration/immutable-tag/immutable-tag.service.ts
...rtal/src/app/shared/services/permission.service.ts
... and 221 more

@YangJiao0817 YangJiao0817 merged commit afec393 into goharbor:release-2.5.0 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants