Skip to content

Conversation

stonezdj
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner April 21, 2025 02:28
@stonezdj stonezdj self-assigned this Apr 21, 2025
@stonezdj stonezdj assigned chlins and unassigned OrlinVasilev, chlins and MinerYang Apr 21, 2025
@stonezdj stonezdj requested review from chlins and wy65701436 April 21, 2025 02:29
Signed-off-by: stonezdj <[email protected]>
@stonezdj stonezdj force-pushed the 25apr17_update_artifact_info branch from 14ef869 to 2056cb9 Compare April 21, 2025 02:30
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.43%. Comparing base (c8c11b4) to head (2056cb9).
Report is 459 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21902      +/-   ##
==========================================
+ Coverage   45.36%   46.43%   +1.06%     
==========================================
  Files         244      253       +9     
  Lines       13333    14233     +900     
  Branches     2719     2924     +205     
==========================================
+ Hits         6049     6609     +560     
- Misses       6983     7274     +291     
- Partials      301      350      +49     
Flag Coverage Δ
unittests 46.43% <ø> (+1.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 178 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 added the release-note/update Update or Fix label Apr 21, 2025
@wy65701436 wy65701436 merged commit a13a163 into goharbor:main Apr 21, 2025
17 of 19 checks passed
wy65701436 pushed a commit to wy65701436/harbor that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants