x/tools/gopls: Completion: "unexpected surrounding: %q != %q" bug in collectCompletions #75192
Description
#!stacks
"bug.Reportf" && "completion.(*completer).selector:+57"
Issue created by stacks.
// -- completion of symbols in unimported packages --
// use new code for unimported completions, if flag allows it
if c.snapshot.Options().ImportsSource == settings.ImportsSourceGopls {
// The user might have typed strings.TLower, so id.Name==strings, sel.Sel.Name == TLower,
// but the cursor might be inside TLower, so adjust the prefix
prefix := sel.Sel.Name
if c.surrounding != nil {
if c.surrounding.content != sel.Sel.Name {
bug.Reportf("unexpected surrounding: %q != %q", c.surrounding.content, sel.Sel.Name)
} else {
prefix = sel.Sel.Name[:c.surrounding.cursor-c.surrounding.start]
}
}
c.unimported(ctx, metadata.PackageName(id.Name), prefix)
return nil
}Possible regression in https://go.dev/cl/667576?
This stack _bvZaw was reported by telemetry:
gopls/buggolang.org/x/tools/gopls/internal/util/bug.report:+35,+0x367golang.org/x/tools/gopls/internal/util/bug.Reportf:+1,+0x27golang.org/x/tools/gopls/internal/golang/completion.(*completer).selector:+57,+0x31bgolang.org/x/tools/gopls/internal/golang/completion.(*completer).collectCompletions:+56,+0x49bgolang.org/x/tools/gopls/internal/golang/completion.Completion:+159,+0xd67golang.org/x/tools/gopls/internal/server.(*server).Completion:+19,+0x1ffgolang.org/x/tools/gopls/internal/protocol.serverDispatch:+193,+0x1cffgolang.org/x/tools/gopls/internal/lsprpc.(*StreamServer).ServeStream.ServerHandler.func4:+5,+0x6fgolang.org/x/tools/gopls/internal/lsprpc.(*StreamServer).ServeStream.handshaker.func5:+52,+0x637golang.org/x/tools/gopls/internal/protocol.Handlers.MustReplyHandler.func1:+2,+0xb3golang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2.2:+3,+0x7fruntime.goexit:+0,+0x3
golang.org/x/tools/[email protected] go1.25.0 darwin/arm64 vscode (1)
Dups: BjtwIw 8lB0bg aoE2jw