Skip to content

Inconsistent value for Token.ExpiresIn #782

@jonathan-conder

Description

@jonathan-conder

Since #746 was fixed, ExpiresIn is now nonzero if the server responds with JSON. But there's another codepath for URL encoded responses:

oauth2/internal/token.go

Lines 297 to 301 in cf14319

e := vals.Get("expires_in")
expires, _ := strconv.Atoi(e)
if expires != 0 {
token.Expiry = time.Now().Add(time.Duration(expires) * time.Second)
}

This one doesn't populate the field.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions