go: module github.com/golang/protobuf is deprecated: Use the "google.golang.org/protobuf" module instead

[yuqx1561]

go get -u -v github.com/hashicorp/consul

[neild]

Yes, github.com/golang/protobuf is deprecated. Can you clarify what you're reporting here?

[harryzcy]

README says that github.com/golang/protobuf is superseded by the google.golang.org/protobuf module. But go.mod of google.golang.org/protobuf still uses github.com/golang/protobuf as a dependency.

Is it the intended behavior or will github.com/golang/protobuf be eventually removed?

[puellanivis]

This is intentional. https://github.com/protocolbuffers/protobuf-go/blob/v1.28.0/internal/weakdeps/doc.go#L5-L11

However, if your program does not actually use anything from github.com/golang/protobuf then it will not be pulled into your binary.

P.S.: It is a wrong assumption that what occurs in a go.mod is actually used in the compiled binary. For instance, many modules import things that are only used during go test. And here, we’re just setting a minimum version that any module that imports both.