add MUJOCO_USE_SYSTEM_TINYXML2 CMake option #2712
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
reviewed
Jul 1, 2025
traversaro
reviewed
Jul 1, 2025
fferri
changed the title
traversaro
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a CMake option
TINYXML2_USE_SYSTEM_PACKAGEMUJOCO_USE_SYSTEM_TINYXML2 (default OFF) to allow users to link against a system-provided installation (via find_package(tinyxml2 REQUIRED)) of tinyxml2 instead of always fetching and building MuJoCo’s bundled copy.Motivation:
If the client program also uses tinyxml2 e.g. links to the system's version of tinyxml2, symbol clashes can occur, especially if the versions are slightly different, which leads to crashes.