-
Notifications
You must be signed in to change notification settings - Fork 1.9k
ci: use pinned nightly rustfmt
to make unstable features take effect
#2896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7577021
update build CI
lucienfer d946cc7
update build CI
lucienfer 87c7128
format
lucienfer ef2d19f
update build.yml
lucienfer f972bf5
rm cargo fmt --all -- --check from ci to put in dprint config file
lucienfer f488614
ci: pin rustfmt to nightly-2025-09-01 in build.yml
lucienfer 5491168
chore(dprint): use rustup run nightly-2025-09-01 rustfmt
lucienfer 59f11c3
xtask: install pinned nightly toolchain in install-tools
lucienfer 99bc33f
docs: update CONTRIBUTING.md with pinned rustfmt instructions
lucienfer 43f26de
dprint: add --version 2024
lucienfer 8dba46a
format + update dprint
lucienfer a180d42
resolve comment
lucienfer cdefe93
fmt
lucienfer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,10 +22,10 @@ jobs: | |
sudo apt update | ||
sudo apt install gettext yapf3 | ||
|
||
- name: Install nightly rustfmt | ||
- name: Install pinned nightly for rustfmt | ||
run: | | ||
rustup default nightly | ||
rustup component add rustfmt | ||
rustup toolchain install --profile minimal nightly-2025-09-01 | ||
rustup component add rustfmt --toolchain nightly-2025-09-01 | ||
|
||
- name: Check formatting | ||
uses: dprint/[email protected] | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! One suggestion: could you use a variable for this so it's easier to update in a few months?
Cc @egithinji, could we use
cargo xtask install-tools
here? Not now, but in a later PR since this just refactors the existing install commands.