Skip to content

Conversation

viveksahu26
Copy link
Contributor

@viveksahu26 viveksahu26 commented May 29, 2025

Fixes: #3581

This PR adds the following changes:

  • It adds up Relationship section in the SBOMs.
  • It also includes externalRefs under the package information.

TODO: Testing need to be added.

@viveksahu26 viveksahu26 marked this pull request as draft May 29, 2025 17:13
@gmlewis gmlewis changed the title [fix]: add mising relationship and pkg external info fix: Add missing relationship and pkg external info for SBOMs May 29, 2025
Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (cc0e642) to head (c11ffa5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3582   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files         184      184           
  Lines       16143    16143           
=======================================
  Hits        14742    14742           
  Misses       1227     1227           
  Partials      174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @viveksahu26!
I know this PR is still a draft, but I wanted to give some early feedback before you got too far in writing the new tests.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label May 31, 2025
@viveksahu26 viveksahu26 marked this pull request as ready for review May 31, 2025 17:30
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label May 31, 2025
Copy link
Contributor

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @viveksahu26!
LGTM.
Merging.

@gmlewis gmlewis merged commit b52ed30 into google:master May 31, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DependencyGraph.GetSBOM() missing important SBOM fields like relationship and package externalRefs
2 participants