-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: Add missing relationship and pkg external info for SBOMs #3582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add missing relationship and pkg external info for SBOMs #3582
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3582 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 184 184
Lines 16143 16143
=======================================
Hits 14742 14742
Misses 1227 1227
Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @viveksahu26!
I know this PR is still a draft, but I wanted to give some early feedback before you got too far in writing the new tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @viveksahu26!
LGTM.
Merging.
Fixes: #3581
This PR adds the following changes:
externalRefs
under the package information.TODO: Testing need to be added.