Skip to content

fix: Change UsageItem.Quantity from int to float64 #3610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
Merged

fix: Change UsageItem.Quantity from int to float64 #3610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34ba363
fix: quantity being a float and not an int
DocEmmetBrown Jun 27, 2025
972ed73
fix generated files. Last iteration was incorrect
DocEmmetBrown Jun 30, 2025
65cc94e
Merge branch 'master' into guillaume/fix-extended-billing
DocEmmetBrown Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion github/billing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ type UsageItem struct {
Date *string `json:"date"`
Product *string `json:"product"`
SKU *string `json:"sku"`
Quantity *int `json:"quantity"`
Quantity *float64 `json:"quantity"`
UnitType *string `json:"unitType"`
PricePerUnit *float64 `json:"pricePerUnit"`
GrossAmount *float64 `json:"grossAmount"`
Expand Down
4 changes: 2 additions & 2 deletions github/billing_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ func TestBillingService_GetUsageReportOrg(t *testing.T) {
Date: Ptr("2023-08-01"),
Product: Ptr("Actions"),
SKU: Ptr("Actions Linux"),
Quantity: Ptr(100),
Quantity: Ptr(100.0),
UnitType: Ptr("minutes"),
PricePerUnit: Ptr(0.008),
GrossAmount: Ptr(0.8),
Expand Down Expand Up @@ -637,7 +637,7 @@ func TestBillingService_GetUsageReportUser(t *testing.T) {
Date: Ptr("2023-08-15"),
Product: Ptr("Codespaces"),
SKU: Ptr("Codespaces Linux"),
Quantity: Ptr(50),
Quantity: Ptr(50.0),
UnitType: Ptr("hours"),
PricePerUnit: Ptr(0.18),
GrossAmount: Ptr(9.0),
Expand Down
10 changes: 5 additions & 5 deletions github/github-accessors.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions github/github-accessors_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading