Update Wasmtime's Rust toolchain #12930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default Rust toolchain use to build Rust projects on OSS-Fuzz, `nightly-2024-07-12`, is too old to build Wasmtime at this time. This toolchain is held back to match the LLVM version that Clang is using (18) and is one of the last Rust nightly builds that still uses LLVM 18 (`nightly-2024-07-30` is the last Rust nightly using 18, `nightly-2024-08-01` uses LLVM 19). In lieu of updating the toolchain for all projects I've opted to only update Wasmtime at this time. I believe this means that Wasmtime will lose coverage information for fuzzing because LLVM tooling is at version 18 whereas Wasmtime will be producing coverage files from LLVM 19. For Wasmtime this is ok as we rely on the fuzzers themselves much more than the retrospective coverage information.
|
alexcrichton is either the primary contact or is in the CCs list of projects/wasmtime. |
oliverchang
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default Rust toolchain use to build Rust projects on OSS-Fuzz,
nightly-2024-07-12, is too old to build Wasmtime at this time. This toolchain is held back to match the LLVM version that Clang is using (18) and is one of the last Rust nightly builds that still uses LLVM 18 (nightly-2024-07-30is the last Rust nightly using 18,nightly-2024-08-01uses LLVM 19).In lieu of updating the toolchain for all projects I've opted to only update Wasmtime at this time. I believe this means that Wasmtime will lose coverage information for fuzzing because LLVM tooling is at version 18 whereas Wasmtime will be producing coverage files from LLVM 19. For Wasmtime this is ok as we rely on the fuzzers themselves much more than the retrospective coverage information.