-
Notifications
You must be signed in to change notification settings - Fork 2.5k
lxc: prepare for llvm 21 #13935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DavidKorczynski
wants to merge
1
commit into
master
Choose a base branch
from
n15
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
lxc: prepare for llvm 21 #13935
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: #13915 (comment) Signed-off-by: David Korczynski <[email protected]>
@evverx are you okay with this? This is the issue we're hitting with llvm 21: Step #23 - "compile-libfuzzer-address-x86_64": �[31mFAILED: [code=1] �[0msrc/lxc/liblxc.a.p/uuid.c.o
Step #23 - "compile-libfuzzer-address-x86_64": clang -Isrc/lxc/liblxc.a.p -Isrc/lxc -I../src/lxc -I. -I.. -Isrc -I../src -Isrc/include -I../src/include -I../src/lxc/cgroups -I../src/lxc/storage -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=gnu11 -O0 -g -Wno-format-signedness -Wno-missing-field-initializers -Wno-unused-parameter -Wvla -Wcast-align -Wstrict-prototypes -fno-strict-aliasing -fstack-clash-protection --param=ssp-buffer-size=4 -Werror=implicit-function-declaration -Wmissing-include-dirs -Wold-style-definition -Winit-self -Wunused-but-set-variable -Wno-unused-parameter -Wfloat-equal -Werror=return-type -Werror=incompatible-pointer-types -Wformat=2 -Wshadow -Wendif-labels -Werror=overflow -fdiagnostics-show-option -Werror=shift-count-overflow -Wdate-time -Wnested-externs -fasynchronous-unwind-tables -fexceptions -Warray-bounds -Wreturn-local-addr -Wno-typedef-redefinition -Wno-gnu-variable-sized-type-not-at-end -ffat-lto-objects -include config.h -O1 -fno-omit-frame-pointer -gline-tables-only -Wno-error=incompatible-function-pointer-types -Wno-error=int-conversion -Wno-error=deprecated-declarations -Wno-error=implicit-function-declaration -Wno-error=implicit-int -Wno-error=unknown-warning-option -Wno-error=vla-cxx-extension -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -fsanitize=address -fsanitize-address-use-after-scope -fsanitize=fuzzer-no-link -fPIC -pthread -fvisibility=default -DIN_LIBLXC -MD -MQ src/lxc/liblxc.a.p/uuid.c.o -MF src/lxc/liblxc.a.p/uuid.c.o.d -o src/lxc/liblxc.a.p/uuid.c.o -c ../src/lxc/uuid.c
Step #23 - "compile-libfuzzer-address-x86_64": �[1m../src/lxc/uuid.c:77:32: �[0m�[0;1;31merror: �[0m�[1minitializer-string for character array is too long, array size is 16 but initializer has size 17 (including the null terminating character); did you mean to use the 'nonstring' attribute? [-Werror,-Wunterminated-string-initialization]�[0m
Step #23 - "compile-libfuzzer-address-x86_64": 77 | �[0;34mstatic�[0m �[0;34mconst�[0m �[0;34mchar�[0m table[�[0;32m16�[0m] = �[0;32m"0123456789abcdef"�[0m;�[0m
Step #23 - "compile-libfuzzer-address-x86_64": | �[0;1;32m ^~~~~~~~~~~~~~~~~~
Step #23 - "compile-libfuzzer-address-x86_64": �[0m1 error generated.
Step #23 - "compile-libfuzzer-address-x86_64": [31/75] clang -Isrc/lxc/liblxc.a.p -Isrc/lxc -I../src/lxc -I. -I.. -Isrc -I../src -Isrc/include -I../src/include -I../src/lxc/cgroups -I../src/lxc/storage -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=gnu11 -O0 -g -Wno-format-signedness -Wno-missing-field-initializers -Wno-unused-parameter -Wvla -Wcast-align -Wstrict-prototypes -fno-strict-aliasing -fstack-clash-protection --param=ssp-buffer-size=4 -Werror=implicit-function-declaration -Wmissing-include-dirs -Wold-style-definition -Winit-self -Wunused-but-set-variable -Wno-unused-parameter -Wfloat-equal -Werror=return-type -Werror=incompatible-pointer-types -Wformat=2 -Wshadow -Wendif-labels -Werror=overflow -fdiagnostics-show-option -Werror=shift-count-overflow -Wdate-time -Wnested-externs -fasynchronous-unwind-tables -fexceptions -Warray-bounds -Wreturn-local-addr -Wno-typedef-redefinition -Wno-gnu-variable-sized-type-not-at-end -ffat-lto-objects -include config.h -O1 -fno-omit-frame-pointer -gline-tables-only -Wno-error=incompatible-function-pointer-types -Wno-error=int-conversion -Wno-error=deprecated-declarations -Wno-error=implicit-function-declaration -Wno-error=implicit-int -Wno-error=unknown-warning-option -Wno-error=vla-cxx-extension -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -fsanitize=address -fsanitize-address-use-after-scope -fsanitize=fuzzer-no-link -fPIC -pthread -fvisibility=default -DIN_LIBLXC -MD -MQ src/lxc/liblxc.a.p/.._include_strlcat.c.o -MF src/lxc/liblxc.a.p/.._include_strlcat.c.o.d -o src/lxc/liblxc.a.p/.._include_strlcat.c.o -c ../src/include/strlcat.c |
I saw that build failure and opened lxc/lxc#4580. I think it would be better to ask @mihalicyn if the lxc project is OK with suppressing that warning for now. My understanding is that it unblocks the LLVM bump so personally I think it's fine to suppress it for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref:
#13915 (comment)