infra: fix flag recognition in bad build checks #13941
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adisuissa fyi |
adisuissa
approved these changes
Sep 5, 2025
|
Tested Envoy: $ python3 infra/helper.py check_build envoy
...
INFO: performing bad build checks for /tmp/not-out/tmp8k2hlhbo/proxy_protocol_fuzz_test
INFO: performing bad build checks for /tmp/not-out/tmp8k2hlhbo/envoy_quic_h3_fuzz_test
INFO: performing bad build checks for /tmp/not-out/tmp8k2hlhbo/json_sanitizer_fuzz_test
INFO:__main__:Check build passed. |
|
/gcbrun trial_build.py all --fuzzing-engines libfuzzer --sanitizers address |
|
Hmm, the trial build fails with which looks to be from 23c943f Will wait to check if the trial build fails in #13915 and if not then perhaps land that PR first. |
|
/gcbrun trial_build.py all --fuzzing-engines libfuzzer --sanitizers address |
This was referenced Sep 9, 2025
Signed-off-by: David Korczynski <[email protected]>
DavidKorczynski
force-pushed
the
DavidKorczynski-patch-14
branch
from
97571d2 to
3b05627
Compare
|
/gcbrun trial_build.py all --fuzzing-engines libfuzzer --sanitizers address |
None of the failures are due to this PR. This is good to go. |
AdamKorcz
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some harnesses won't recognise the flags if
--is not supplied, causing the bad build check to run the fuzzers forever or until they crash. This happens for Envoy.Tested this works on other projects as well, but will do a bit more testing before it's ready.