Migrate TUI to new build API #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algomaster99
previously requested changes
Aug 22, 2025
msuozzo
reviewed
Aug 22, 2025
wbxyz
force-pushed
the
push-ultsrxlqpklu
branch
3 times, most recently
from
cf90e39 to
358416d
Compare
wbxyz
force-pushed
the
push-ultsrxlqpklu
branch
from
358416d to
66d2ae1
Compare
msuozzo
approved these changes
Sep 23, 2025
wbxyz
force-pushed
the
push-ultsrxlqpklu
branch
from
66d2ae1 to
fa28a99
Compare
wbxyz
force-pushed
the
push-ultsrxlqpklu
branch
from
fa28a99 to
3aa53bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One notable change, I removed the ability to run a benchmark from TUI.
I decided that any "run local" in the TUI should be ephermeral, and shouldn't produce rundex logging.
I think running benchmarks with local-state is still important to support, but might be cleaner to implement outside the UI code and instead use run-bench to trigger the rebuilds. TBD how I want run-bench to write the artifacts locally, but we could probably re-use apiservice/rebuild.go implementation just with a different set of deps.