Add benchmark for grouping by GroupID for maven packages #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wbxyz should we do this in the SQL query instead? Although the tables don't seem to have individual group and artifact columns. |
msuozzo
approved these changes
Sep 3, 2025
algomaster99
force-pushed
the
push-yzsxuuppsrtq
branch
from
c4f13aa to
def2985
Compare
algomaster99
force-pushed
the
push-yzsxuuppsrtq
branch
from
def2985 to
c28d47d
Compare
|
I added another benchmark |
algomaster99
changed the title
wbxyz
reviewed
Sep 12, 2025
| } | ||
| close(pkgs) | ||
| }() | ||
| seenGroups := make(map[string]struct{}) |
There was a problem hiding this comment.
If this were a map[string]bool then you can assign true as the value and just do something like if seenGroups[g] { ...
| if len(psp.Versions) >= 5 { | ||
| continue | ||
| } | ||
| nameParts := strings.SplitN(p.Package, ":", 2) |
There was a problem hiding this comment.
Can this be combined with the group split above?
| log.Fatal(err.Error()) | ||
| } | ||
| query := client.Query(` | ||
| SELECT |
There was a problem hiding this comment.
I think this SQL needs to be updated following some of the other PRs
|
Achieved by #772. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During inference, the errors are often duplicated in the same group ID. This will ensure that benchmark has unique group IDs and which roughly implies unique source repositories.