Skip to content

fix(idtoken): don't assume DefaultTransport is a http.Transport #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

fix(idtoken): don't assume DefaultTransport is a http.Transport #3263

merged 1 commit into from
Aug 6, 2025

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Aug 6, 2025

Fixes: #3260

@codyoss codyoss requested a review from a team as a code owner August 6, 2025 14:52
@codyoss codyoss requested a review from quartzmo August 6, 2025 14:53
quartzmo
quartzmo approved these changes Aug 6, 2025
View reviewed changes
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix. I thought we got rid of all of these hard-coded casts, but apparently there was still one at least.

@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2025
@codyoss codyoss merged commit 61fba51 into googleapis:main Aug 6, 2025
5 checks passed
@release-please release-please bot mentioned this pull request Aug 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartzmo quartzmo quartzmo approved these changes

Assignees
No one assigned
Labels
kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

idtoken.NewClient panics if http.DefaultTransport is not a *http.Transport
2 participants
@codyoss @quartzmo