README: convert key to bytes before passing to NewCookieStore #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

elithrar merged 1 commit into gorilla:master from nikhita:readme-secret-byte

Nov 27, 2018

Contributor

nikhita commented Nov 27, 2018

os.Getenv will return a string, but NewCookieStore takes bytes as the argument:

sessions/store.go

Line 50 in 68d1ede

func NewCookieStore(keyPairs ...[]byte) *CookieStore {


          README: convert key to bytes before passing to NewCookieStore

6f79329

Contributor

elithrar commented Nov 27, 2018

Good catch, thanks!

elithrar merged commit 4109461 into gorilla:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet