Skip to content

fix CookieStore creation in doc.go #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2020
Merged

fix CookieStore creation in doc.go #206

merged 1 commit into from
Jan 5, 2020

Conversation

collinewait
Copy link
Contributor

Fixes the creation of CookieStore in doc.go

Summary of Changes

  1. sessions.NewCookieStore method requires a slice of bytes but a string was provided in doc.go file.

elithrar
elithrar approved these changes Jan 5, 2020
View reviewed changes
Copy link
Contributor

@elithrar elithrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - thanks.

@elithrar elithrar merged commit 15ff351 into gorilla:master Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@elithrar elithrar elithrar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@collinewait @elithrar