Test with Typescript 5.9

[domoritz]

https://devblogs.microsoft.com/typescript/announcing-typescript-5-9/ is out with some changes that could affect type checks for this library.

[kainino0x]

Are there specific changes that you think require changes in our types? I see there are fixes to the types for ArrayBuffer and typed arrays but off the top of my head I don't think those would impact us.

[domoritz]

I originally thought that ts 5.9 is the reason why I had some type errors in apple/embedding-atlas#15 which I eventually resolved by not allowing shared array buffers: apple/embedding-atlas@7d260f9.

Without those changes, I get the following error

src/lib/webgpu_renderer/renderer.ts:218:73 - error TS2322: Type 'ValueNode<Float32Array<ArrayBufferLike>>' is not assignable to type 'BufferSource | Node<BufferSource | null> | null'.
  Type 'ValueNode<Float32Array<ArrayBufferLike>>' is not assignable to type 'Node<BufferSource | null>'.
    Types of property '_value' are incompatible.
      Type 'Float32Array<ArrayBufferLike> | null' is not assignable to type 'BufferSource | null'.
        Type 'Float32Array<ArrayBufferLike>' is not assignable to type 'BufferSource | null'.
          Type 'Float32Array<ArrayBufferLike>' is not assignable to type 'ArrayBufferView<ArrayBuffer>'.
            Types of property 'buffer' are incompatible.
              Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'.
                Type 'SharedArrayBuffer' is missing the following properties from type 'ArrayBuffer': resizable, resize, detached, transfer, transferToFixedLength

218     [device, df.statefulDerive([device, xyDataSize, usage], gpuBuffer), inputs.xData],
                                                                            ~~~~~~~~~~~~
src/lib/webgpu_renderer/renderer.ts:222:73 - error TS2322: Type 'ValueNode<Float32Array<ArrayBufferLike>>' is not assignable to type 'BufferSource | Node<BufferSource | null> | null'.
  Type 'ValueNode<Float32Array<ArrayBufferLike>>' is not assignable to type 'Node<BufferSource | null>'.
    Types of property '_value' are incompatible.
      Type 'Float32Array<ArrayBufferLike> | null' is not assignable to type 'BufferSource | null'.
        Type 'Float32Array<ArrayBufferLike>' is not assignable to type 'BufferSource | null'.
          Type 'Float32Array<ArrayBufferLike>' is not assignable to type 'ArrayBufferView<ArrayBuffer>'.
            Types of property 'buffer' are incompatible.
              Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'.
                Type 'SharedArrayBuffer' is missing the following properties from type 'ArrayBuffer': resizable, resize, detached, transfer, transferToFixedLength

222     [device, df.statefulDerive([device, xyDataSize, usage], gpuBuffer), inputs.yData],
                                                                            ~~~~~~~~~~~~
src/lib/webgpu_renderer/renderer.ts:226:79 - error TS2322: Type 'ValueNode<Uint8Array<ArrayBufferLike> | null>' is not assignable to type 'BufferSource | Node<BufferSource | null> | null'.
  Type 'ValueNode<Uint8Array<ArrayBufferLike> | null>' is not assignable to type 'Node<BufferSource | null>'.
    Types of property '_value' are incompatible.
      Type 'Uint8Array<ArrayBufferLike> | null' is not assignable to type 'BufferSource | null'.
        Type 'Uint8Array<ArrayBufferLike>' is not assignable to type 'BufferSource | null'.
          Type 'Uint8Array<ArrayBufferLike>' is not assignable to type 'ArrayBufferView<ArrayBuffer>'.
            Types of property 'buffer' are incompatible.
              Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'.
                Type 'SharedArrayBuffer' is missing the following properties from type 'ArrayBuffer': resizable, resize, detached, transfer, transferToFixedLength

226     [device, df.statefulDerive([device, categoryDataSize, usage], gpuBuffer), inputs.categoryData],
                                                                                  ~~~~~~~~~~~~~~~~~~~

But you are probably right that ithe ts version may not matter so feel free to close.

[kainino0x]

We should test with 5.9 anyway, so I will leave this open to do that even though I don't suspect it will fail.

Contributions welcome from anyone who reads this - it's very easy, just add a new directory to the tests (https://github.com/gpuweb/types/tree/main/tests) and it'll be picked up automatically by npm test.

It would also be nice to set up a test with typescript 6.0.0-dev.*, but I don't know if it will work yet or not. (Also I don't know if there's a way to tell npm to get the latest 6.0 dev release since it's not actually released yet.)

[kainino0x]

which I eventually resolved by not allowing shared array buffers: apple/embedding-atlas@7d260f9.

It's generally useful for libraries to be able to integrate with SharedArrayBuffer, so I would suggest trying to make it work. Try Node<AllowSharedBufferSource | null> or something like that.