Update headers are empty check on INJECT_HEADERS #916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An empty headers dict currently is not treated as having 'no headers to inject' Discussed in: graphql#893
|
|
|
headers can be any in props: but are typed as strings in the injectheaders prop: and (as far as i can tell in my local use) are sent as an object, which when empty is still considered to have headers to inject |
|
@zhammer Thanks for your PR! It will be in the next version of playground. |
RenovZ
pushed a commit
to RenovZ/graphql-playground
that referenced
this pull request
Mar 25, 2022
* Update headers are empty check on INJECT_HEADERS An empty headers dict currently is not treated as having 'no headers to inject' Discussed in: graphql#893 * Accidentally changed line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An empty headers dict currently is not treated as having 'no headers to inject'
Discussed in: #893
Fixes #893 (at least in the case where headers are empty).
Changes proposed in this pull request: