-
-
Notifications
You must be signed in to change notification settings - Fork 844
Closed
Labels
Complexity: MediumP-Feature: Wins Pagehttps://www.hackforla.org/wins/https://www.hackforla.org/wins/role: back end/devOpsTasks for back-end developersTasks for back-end developersrole: front endTasks for front end developersTasks for front end developerssize: 0.5ptCan be done in 3 hours or lessCan be done in 3 hours or lesstime sensitiveNeeds to be worked on by a particular timeframeNeeds to be worked on by a particular timeframe
Milestone
Description
Overview
We need to update the website/assets/js/wins.js
file on line 31 to exclude the invalid $
character in order to prevent the wins page from crashing.
Action Items
- In the
website/assets/js/wins.js
file on line 31, update$community.svg
tocommunity.svg
by removing the$
character. - Verify the change by developing a test procedure to ensure that the wins page (
https://localhost:4000/wins
) renders correctly when "I became part of a caring community." is selected in the "What do you want to celebrate (select all that apply)?" field inwebsite/_data/external/_wins-data.json
.- The
community.svg
icon (website/assets/images/wins-page/wins-badges/community.svg
) should display under the developer’s summary section if "I became part of a caring community." is included in their responses.
** Hint: You may manually edit website/_data/external/_wins-data.json on a separate test branch to simulate a selection on the "Share your wins with us" form.
- The
- In your PR, include an explanation of the testing you performed and relevant screenshots.
Resources/Instructions
wins.js
file:website/assets/js/wins.js
- Data file:
website/_data/external/_wins-data.json
- Icon file:
website/assets/images/wins-page/wins-badges/community.svg
- demo video by @daras-cu showing wins page user information update: video demo
- This issue came from this ER ER: Remove Extraneous
$
inwins.js
#8147
Metadata
Metadata
Assignees
Labels
Complexity: MediumP-Feature: Wins Pagehttps://www.hackforla.org/wins/https://www.hackforla.org/wins/role: back end/devOpsTasks for back-end developersTasks for back-end developersrole: front endTasks for front end developersTasks for front end developerssize: 0.5ptCan be done in 3 hours or lessCan be done in 3 hours or lesstime sensitiveNeeds to be worked on by a particular timeframeNeeds to be worked on by a particular timeframe
Type
Projects
Status
QA