-
-
Notifications
You must be signed in to change notification settings - Fork 843
Remove Extraneous $
in wins.js
#8306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Extraneous $
in wins.js
#8306
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 9/3/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this issue @lc1715 !
Things Done Well
- Pull request description and images accurately describes changes and why they were made
- Instructions for testing are easy to follow, and clearly communicate how to view changes
- Only the requested file in the issue is changed, and website works as expected after changes
- Code does not trigger any Code QL alerts(Member Activity Trigger can be ignored for now)
Changes to Make
None
I approve this pull request.
Availability: after 1pm (pacific) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your hard work, lc1715!
Things Done Well
-
The pull request was done with the correct branch.
-
There's a linked issue. I read it and watched the demo to better understand things.
-
Your deletion shown in the Files Changed tab looks good.
Suggestions
- none
I'd like to approve this PR.
Fixes #8289
What changes did you make?
$
and typo in thewins.js
fileWhy did you make the changes (we will use this info to test)?
website/assets/js/wins.js
file on line 31 to exclude the invalid$
character in order to prevent the wins page from crashing.community.svg
icon (website/assets/images/wins-page/wins-badges/community.svg
) displays under the developer’s summary section if "I became part of a caring community" is included in the "What do you want to celebrate (select all that apply)?" field inwebsite/_data/external/_wins-data.json
.Test Procedure
website/_data/external/_wins-data.json
filedocker-compose up
from a terminal windowhttps://localhost:4000/wins
in your browser windowcommunity.svg
iconwebsite/_data/external/_wins-data.json
file and saveCodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Relevant Screenshots
Visuals before testing changes are applied
Visuals after testing changes are applied