Skip to content

Conversation

lc1715
Copy link
Member

@lc1715 lc1715 commented Aug 31, 2025

Fixes #8289

What changes did you make?

  • Removed the extraneous $ and typo in the wins.js file

Why did you make the changes (we will use this info to test)?

  • We need to update the website/assets/js/wins.js file on line 31 to exclude the invalid $ character in order to prevent the wins page from crashing.
  • We also need to ensure the community.svg icon (website/assets/images/wins-page/wins-badges/community.svg) displays under the developer’s summary section if "I became part of a caring community" is included in the "What do you want to celebrate (select all that apply)?" field in website/_data/external/_wins-data.json.

Test Procedure

  1. Go to the website/_data/external/_wins-data.json file
  2. Add the testing object below as the last item in the array and save it
{
          "Timestamp": "2025-08-29T00:40:59.045Z",
          "Email Address": "[email protected]",
          "Full name": "Testing",
          "Linkedin URL (optional)": "https://www.linkedin.com",
          "Could we use your Linkedin profile picture next to your story?": "Yes",
          "Github URL (optional)": "https://github.com",
          "Could we use your Github profile picture next to your story?": "No",
          "Select the team(s) you're on": "HackforLA Website",
          "Select your role(s) on the team": "Development",
          "What is/was your specific role? (optional)": "test",
          "When did you join Hack for LA? (optional)": "2023-08-11T07:00:00.000Z",
          "What do you want to celebrate (select all that apply)?": "I got a new job, I produced something for my portfolio, I improved my LinkedIn, I became part of a caring community",
          "Give us a brief overview": "Test response",
          "Display?": true,
          "Homepage?": false
     }
  1. Open the Docker Desktop application and run the command docker-compose up from a terminal window
  2. View the changes on the wins page at https://localhost:4000/wins in your browser window
  3. The community.svg icon community.svg icon should display under the developer’s summary section
  4. Remove the testing object from the website/_data/external/_wins-data.json file and save

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Relevant Screenshots

Visuals before testing changes are applied wins page before testing changes
Visuals after testing changes are applied wins page after testing changes detailed information about the individual

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b lc1715-remove-extraneous-characters-8289 gh-pages
git pull https://github.com/lc1715/website.git remove-extraneous-characters-8289

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium time sensitive Needs to be worked on by a particular timeframe P-Feature: Wins Page https://www.hackforla.org/wins/ size: 0.5pt Can be done in 3 hours or less labels Aug 31, 2025
@lc1715 lc1715 mentioned this pull request Aug 31, 2025
5 tasks
@caz002 caz002 self-requested a review August 31, 2025 17:13
@caz002
Copy link
Member

caz002 commented Aug 31, 2025

Review ETA: 9/3/25
Availability: after 7pm on Weekdays

Copy link
Member

@caz002 caz002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this issue @lc1715 !

Things Done Well

  • Pull request description and images accurately describes changes and why they were made
  • Instructions for testing are easy to follow, and clearly communicate how to view changes
  • Only the requested file in the issue is changed, and website works as expected after changes
  • Code does not trigger any Code QL alerts(Member Activity Trigger can be ignored for now)

Changes to Make

None

I approve this pull request.

@daras-cu daras-cu requested a review from kdaca19xx September 10, 2025 02:15
@kdaca19xx
Copy link
Member

kdaca19xx commented Sep 10, 2025

Availability: after 1pm (pacific)
ETA: 9/14

Copy link
Member

@kdaca19xx kdaca19xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your hard work, lc1715!

Things Done Well

  • The pull request was done with the correct branch.

  • There's a linked issue. I read it and watched the demo to better understand things.

  • Your deletion shown in the Files Changed tab looks good.

Suggestions

  • none

I'd like to approve this PR.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Sep 14, 2025
@daras-cu daras-cu merged commit bb3ed4a into hackforla:gh-pages Sep 14, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Remove Extraneous $ in wins.js
4 participants