-
-
Notifications
You must be signed in to change notification settings - Fork 843
Remove Sarah Edwards from Guides Team #8302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Sarah Edwards from Guides Team #8302
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Nubila. Good work completing this pull request.
Done well
- The merge to and from branches are correct.
- The originating issue is correctly linked.
- The pull request description is correctly filled out.
- You've correctly assigned yourself in the originating issue, as well as set the correct status for it.
Suggestions
- In the originating issue, you forgot to check off the action items. In my opinion, it is not a big deal for good first issues, but in the future, please ensure that you check those off.
- In your pull request description, you should remove empty bullet points to make it more concise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nubilaxl This looks great-
- branches from and to are correct,
- the original issue is linked
- the "What was changed.." and "Why.." are brief and descriptive
- there are 'before' and 'after' screenshots attached
- the code changes edits are good
This is ready to be merged- as @myronchen-git mentioned, there are a couple of minor items: please remove the empty bullet points under the "What.." and "Why..." , and on the original issue please check off the "Action Items" that you completed. After that, this can be merged.
Thank you for working on the is issue
@nubilaxl FYI- Please ignore the 'failing check' for "Member Activity Trigger" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nubilaxl I see you made the changes @t-will-gillis requested, good job on this issue. It is ready to merge.
Fixes #8086
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied