Skip to content

Conversation

nubilaxl
Copy link
Member

@nubilaxl nubilaxl commented Aug 28, 2025

Fixes #8086

What changes did you make?

  • Removed Sarah Edwards from the Guides Team leadership page

Why did you make the changes (we will use this info to test)?

  • To keep project information up to date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied Screenshot 2025-08-27 at 8 59 59 PM
Visuals after changes are applied Screenshot 2025-08-27 at 9 09 12 PM

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b nubilaxl-remove-sarah-edwards-8086 gh-pages
git pull https://github.com/nubilaxl/website.git remove-sarah-edwards-8086

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 28, 2025
Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nubila. Good work completing this pull request.


Done well

  • The merge to and from branches are correct.
  • The originating issue is correctly linked.
  • The pull request description is correctly filled out.
  • You've correctly assigned yourself in the originating issue, as well as set the correct status for it.

Suggestions

  • In the originating issue, you forgot to check off the action items. In my opinion, it is not a big deal for good first issues, but in the future, please ensure that you check those off.
  • In your pull request description, you should remove empty bullet points to make it more concise.

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nubilaxl This looks great-

  • branches from and to are correct,
  • the original issue is linked
  • the "What was changed.." and "Why.." are brief and descriptive
  • there are 'before' and 'after' screenshots attached
  • the code changes edits are good

This is ready to be merged- as @myronchen-git mentioned, there are a couple of minor items: please remove the empty bullet points under the "What.." and "Why..." , and on the original issue please check off the "Action Items" that you completed. After that, this can be merged.

Thank you for working on the is issue

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Sep 3, 2025
@t-will-gillis
Copy link
Member

@nubilaxl FYI- Please ignore the 'failing check' for "Member Activity Trigger"

Copy link
Member

@daras-cu daras-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nubilaxl I see you made the changes @t-will-gillis requested, good job on this issue. It is ready to merge.

@daras-cu daras-cu merged commit a0595cc into hackforla:gh-pages Sep 14, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Guides Team - Remove Sarah Edwards
4 participants