suppress and fix lint errors by unused #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijeetviswa
force-pushed
the
lint-unused
branch
from
8ba0dab to
c5672f8
Compare
mukeshjc
previously approved these changes
May 26, 2025
|
Took a look at this PR and realised the
|
abhijeetviswa
commented
May 27, 2025
There was a problem hiding this comment.
This file was regenerated by running go generate ./hclsyntax/generate.go and undoes changes made in 314d236.
abhijeetviswa
commented
May 27, 2025
There was a problem hiding this comment.
This file was regenerated by running go generate ./hclsyntax/generate.go and undoes changes in 314d236.
added 4 commits
June 2, 2025 12:25
The majority of unused declarations were one of 3 types:
- Global constants or sentinel variables. These were untouched becuse
they serve as documentation and may become useful in the future.
- Variable declarations to assert a struct implements an interface.
These are compile time safety nets and were also ountouched.
- Runtime function
- Unused fields in structs. These were removed to reduce overall
since they serve no purpose and at best increase memory consumption
and at worst make such structs more confusing to the reader.
There was also an undocumented private function that was removed. It
was straightforward and can be reimplemented if need be.
adding nolint directives to the generates files don't make sense if they get rewritten. Instead, the errors are being ignored through the golangci-lint config file.
abhijeetviswa
force-pushed
the
lint-unused
branch
from
7898dba to
dbee716
Compare
mukeshjc
approved these changes
Jun 2, 2025
liamcervante
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of unused declarations were one of these types:
_