Multiplatform support for the docker image #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog WarningPlease add a changelog entry to |
gautambaghel
requested changes
Aug 19, 2025
| # devbuild compiles the binary | ||
| # ----------------------------------- | ||
| FROM golang:1.24.4-alpine@sha256:e5c2e59960f8636d02f77029c8f0a7a6b882f87fee8d2e4a9ce6c9ff112ed735 AS devbuild | ||
| FROM golang:1.24.4-alpine AS devbuild |
There was a problem hiding this comment.
Could we make sure this is pinned to a SHA instead of alpine in general?
| COPY . ./ | ||
| # Build the server | ||
| RUN --mount=type=cache,target=/root/.cache/go-build CGO_ENABLED=0 go build -ldflags="-s -w -X terraform-mcp-server/version.GitCommit=$(shell git rev-parse HEAD) -X terraform-mcp-server/version.BuildDate=$(shell git show --no-show-signature -s --format=%cd --date=format:'%Y-%m-%dT%H:%M:%SZ' HEAD)" \ | ||
| RUN --mount=type=cache,target=/root/.cache/go-build \ |
There was a problem hiding this comment.
we need the version commit and build Date information, please put them back
| # Build multi-platform docker image | ||
| docker-build: | ||
| $(DOCKER) build --build-arg VERSION=$(VERSION) -t $(BINARY_NAME):$(VERSION) . | ||
| $(DOCKER) buildx build --platform linux/amd64,linux/arm64 \ |
There was a problem hiding this comment.
This is meant for local deployment only, which is satisfactory unless you think otherwise? When we actually deploy the container image we do it for most arch (armv6, arm64, amd64, 386 )--> https://hub.docker.com/r/hashicorp/terraform-mcp-server/tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.
Added multi-platform support when building the Docker image, it was defaulting to amd64 arch