make command(inspired from vim) #14328
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change visibility of parsing functions change into_iter function to IntoIterator trait
plus impl Index traits for list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dont think this is finished, its still missing things like displaying inline text in the same way diagnostics do(and also make it possible to turn it off in the config), or probably a few additional regex'es to make it more useful for more people, or probably some tests, but i won't have the time now to implement these now, so figured might as well send the pull request.
I still think its a good start for a feature i've seen was requested by people(and myself).
From testing for a couple days with mainly gcc/clang output it works great.
Here are some suggestions for future development if this ever gets integrated into the codebase, that i didnt have time to implement:
The fact you need to either retype the command(or press the up-arrow a few times) all the time is kind of annoying, maybe it would be nice to specify some commands in the config, and then have a picker over them.
It would be nice to somehow see the full output of the command.
It would be nice to see the returned code by the command.