Skip to content

Conversation

angela-young
Copy link
Contributor

@angela-young angela-young commented Sep 8, 2025

This PR updates as many packages with as few major breaking changes as possible in order to fix high severity dependabot alerts. There will be follow up PR(s) made to address the packages that will need major updates in order to address the remaining vulnerabilities.

There are 42 dependabot alerts at the time of creating this PR. After merging, there are now 13.
GUS: W-19586252

Changes made:

High severity alerts that should also resolve as a result of the changes made above:

To test:

  • pull down this branch
  • run yarn install && yarn build
  • verify there are no errors
  • run yarn test
  • verify all tests pass
  • run yarn link

In herokudata-frontend repo:

  • run yarn link "@heroku/react-hk-components"
  • run yarn && yarn start
  • the local environment should open on its own, and if not, go to http://localhost:3000/
  • verify the hk components on the site work as expected
    • click the table column headers to change the sorting direction
    • click the dataclips page tab
    • search for "con" and click the first result
    • click around and verify the chart view loads as expected (image below)
    • feel free to go back and open other dataclip pages
    • click the "New Dataclip" button
    • search for "aer" and click the first result
    • click through the dropdowns in the schema explorer on the right (image below)
    • verify the dropdown next to the "Save & Run" button works as expected
Screenshot 2025-09-10 at 1 44 28 PM Screenshot 2025-09-10 at 1 45 33 PM

Next steps

The three major sources of vulnerabilities are webpack, eslint, and jest. Updating any of these packages will likely have major breaking changes, which is why I plan to split them out into separate PRs.

@angela-young angela-young requested a review from a team as a code owner September 8, 2025 19:30
@angela-young angela-young marked this pull request as draft September 8, 2025 19:30
@heroku heroku bot temporarily deployed to react-hk-com-ay-3pp-hig-zrt78a September 8, 2025 19:30 Inactive
@heroku heroku bot temporarily deployed to react-hk-com-ay-3pp-hig-zrt78a September 8, 2025 22:04 Inactive
@heroku heroku bot temporarily deployed to react-hk-com-ay-3pp-hig-zrt78a September 9, 2025 16:47 Inactive
@heroku heroku bot temporarily deployed to react-hk-com-ay-3pp-hig-zrt78a September 9, 2025 18:02 Inactive
@heroku heroku bot temporarily deployed to react-hk-com-ay-3pp-hig-zrt78a September 9, 2025 19:52 Inactive
@heroku heroku bot temporarily deployed to react-hk-com-ay-3pp-hig-zrt78a September 9, 2025 19:53 Inactive
@heroku heroku bot temporarily deployed to react-hk-com-ay-3pp-hig-zrt78a September 9, 2025 19:53 Inactive
@heroku heroku bot temporarily deployed to react-hk-com-ay-3pp-hig-zrt78a September 9, 2025 19:59 Inactive
Comment on lines +30 to +37
new CopyWebpackPlugin({
patterns: [
{
from: path.resolve(__dirname, './src/static'),
to: path.resolve(__dirname, './dist/static'),
},
],
}),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was made due to updating copy-webpack-plugin

@heroku heroku bot temporarily deployed to react-hk-com-ay-3pp-hig-zrt78a September 9, 2025 20:23 Inactive
@heroku heroku bot temporarily deployed to react-hk-com-ay-3pp-hig-zrt78a September 9, 2025 23:58 Inactive
@heroku heroku bot temporarily deployed to react-hk-com-ay-3pp-hig-zrt78a September 10, 2025 00:08 Inactive
@heroku heroku bot temporarily deployed to react-hk-com-ay-3pp-hig-zrt78a September 10, 2025 17:08 Inactive
Copy link
Contributor

@angeldcampbell angeldcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! tested locally without issues

Copy link
Contributor

@kenyaplenty kenyaplenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Everything worked for me locally for the most part except for when there were error related to dataclip queries (I don't think this is you!)

@angela-young angela-young merged commit 152cf03 into main Sep 10, 2025
2 checks passed
@angela-young angela-young deleted the ay/3pp-high-sev-deps branch September 10, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants