-
Notifications
You must be signed in to change notification settings - Fork 7
Updating packages to address high severity alerts #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
new CopyWebpackPlugin({ | ||
patterns: [ | ||
{ | ||
from: path.resolve(__dirname, './src/static'), | ||
to: path.resolve(__dirname, './dist/static'), | ||
}, | ||
], | ||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was made due to updating copy-webpack-plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! tested locally without issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Everything worked for me locally for the most part except for when there were error related to dataclip queries (I don't think this is you!)
This PR updates as many packages with as few major breaking changes as possible in order to fix high severity dependabot alerts. There will be follow up PR(s) made to address the packages that will need major updates in order to address the remaining vulnerabilities.
There are 42 dependabot alerts at the time of creating this PR. After merging, there are now 13.
GUS: W-19586252
Changes made:
react-hot-loader
andreact-select
uglifyjs-webpack-plugin
→terser-webpack-plugin
eslint-plugin-node
to addresssemver
vulnlint-staged
andbabel-jest
to addressbraces
vulncopy-webpack-plugin
,webpack
, andwebpack-cli
to addressssri
babel-loader
,css-loader
,mini-css-extract-plugin
,style-loader
, andfile-loader
to addressjson5
d3
ford3-color
vuln. Also upgradedbabel-core
to@babel/core
along with related packages, and replaced.babelrc
with.babelrc.js
as part of the breaking changes involved with upgradingwebpack-bundle-analyzer
to removebody-parser
vulnnp
andjest-css-modules-transform
fordot-prop
vulnnp
(again) andwebpack-cli
to addressini
vulnHigh severity alerts that should also resolve as a result of the changes made above:
To test:
yarn install && yarn build
yarn test
yarn link
In herokudata-frontend repo:
yarn link "@heroku/react-hk-components"
yarn && yarn start
Next steps
The three major sources of vulnerabilities are
webpack
,eslint
, andjest
. Updating any of these packages will likely have major breaking changes, which is why I plan to split them out into separate PRs.