Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rare-kangaroos-try.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hey-api/openapi-ts": patch
---

fix(axios): remove duplicate `baseURL` when using relative values
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const createClient = (config: Config = {}): Client => {
const { auth, ...optsWithoutAuth } = opts;
const response = await _axios({
...optsWithoutAuth,
baseURL: opts.baseURL as string,
baseURL: '', // the baseURL is already included in `url`
data: getValidRequestBody(opts),
headers: opts.headers as RawAxiosRequestHeaders,
// let `paramsSerializer()` handle query params if it exists
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ type BuildUrlFn = <
url: string;
},
>(
options: Pick<TData, 'url'> & Omit<Options<TData>, 'axios'>,
options: Pick<TData, 'url'> & Options<TData>,
) => string;

export type Client = CoreClient<
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,16 @@ export const setAuthParams = async ({
}
};

export const buildUrl: Client['buildUrl'] = (options) =>
getUrl({
baseUrl: options.baseURL as string,
export const buildUrl: Client['buildUrl'] = (options) => {
const instanceBaseUrl = options.axios?.defaults?.baseURL;

const baseUrl =
!!options.baseURL && typeof options.baseURL === 'string'
? options.baseURL
: instanceBaseUrl;

return getUrl({
baseUrl: baseUrl as string,
path: options.path,
// let `paramsSerializer()` handle query params if it exists
query: !options.paramsSerializer ? options.query : undefined,
Expand All @@ -137,6 +144,7 @@ export const buildUrl: Client['buildUrl'] = (options) =>
: createQuerySerializer(options.querySerializer),
url: options.url,
});
};

export const mergeConfigs = (a: Config, b: Config): Config => {
const config = { ...a, ...b };
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const createClient = (config: Config = {}): Client => {
const { auth, ...optsWithoutAuth } = opts;
const response = await _axios({
...optsWithoutAuth,
baseURL: opts.baseURL as string,
baseURL: '', // the baseURL is already included in `url`
data: getValidRequestBody(opts),
headers: opts.headers as RawAxiosRequestHeaders,
// let `paramsSerializer()` handle query params if it exists
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ type BuildUrlFn = <
url: string;
},
>(
options: Pick<TData, 'url'> & Omit<Options<TData>, 'axios'>,
options: Pick<TData, 'url'> & Options<TData>,
) => string;

export type Client = CoreClient<
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,16 @@ export const setAuthParams = async ({
}
};

export const buildUrl: Client['buildUrl'] = (options) =>
getUrl({
baseUrl: options.baseURL as string,
export const buildUrl: Client['buildUrl'] = (options) => {
const instanceBaseUrl = options.axios?.defaults?.baseURL;

const baseUrl =
!!options.baseURL && typeof options.baseURL === 'string'
? options.baseURL
: instanceBaseUrl;

return getUrl({
baseUrl: baseUrl as string,
path: options.path,
// let `paramsSerializer()` handle query params if it exists
query: !options.paramsSerializer ? options.query : undefined,
Expand All @@ -137,6 +144,7 @@ export const buildUrl: Client['buildUrl'] = (options) =>
: createQuerySerializer(options.querySerializer),
url: options.url,
});
};

export const mergeConfigs = (a: Config, b: Config): Config => {
const config = { ...a, ...b };
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const createClient = (config: Config = {}): Client => {
const { auth, ...optsWithoutAuth } = opts;
const response = await _axios({
...optsWithoutAuth,
baseURL: opts.baseURL as string,
baseURL: '', // the baseURL is already included in `url`
data: getValidRequestBody(opts),
headers: opts.headers as RawAxiosRequestHeaders,
// let `paramsSerializer()` handle query params if it exists
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ type BuildUrlFn = <
url: string;
},
>(
options: Pick<TData, 'url'> & Omit<Options<TData>, 'axios'>,
options: Pick<TData, 'url'> & Options<TData>,
) => string;

export type Client = CoreClient<
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,16 @@ export const setAuthParams = async ({
}
};

export const buildUrl: Client['buildUrl'] = (options) =>
getUrl({
baseUrl: options.baseURL as string,
export const buildUrl: Client['buildUrl'] = (options) => {
const instanceBaseUrl = options.axios?.defaults?.baseURL;

const baseUrl =
!!options.baseURL && typeof options.baseURL === 'string'
? options.baseURL
: instanceBaseUrl;

return getUrl({
baseUrl: baseUrl as string,
path: options.path,
// let `paramsSerializer()` handle query params if it exists
query: !options.paramsSerializer ? options.query : undefined,
Expand All @@ -137,6 +144,7 @@ export const buildUrl: Client['buildUrl'] = (options) =>
: createQuerySerializer(options.querySerializer),
url: options.url,
});
};

export const mergeConfigs = (a: Config, b: Config): Config => {
const config = { ...a, ...b };
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const createClient = (config: Config = {}): Client => {
const { auth, ...optsWithoutAuth } = opts;
const response = await _axios({
...optsWithoutAuth,
baseURL: opts.baseURL as string,
baseURL: '', // the baseURL is already included in `url`
data: getValidRequestBody(opts),
headers: opts.headers as RawAxiosRequestHeaders,
// let `paramsSerializer()` handle query params if it exists
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ type BuildUrlFn = <
url: string;
},
>(
options: Pick<TData, 'url'> & Omit<Options<TData>, 'axios'>,
options: Pick<TData, 'url'> & Options<TData>,
) => string;

export type Client = CoreClient<
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,16 @@ export const setAuthParams = async ({
}
};

export const buildUrl: Client['buildUrl'] = (options) =>
getUrl({
baseUrl: options.baseURL as string,
export const buildUrl: Client['buildUrl'] = (options) => {
const instanceBaseUrl = options.axios?.defaults?.baseURL;

const baseUrl =
!!options.baseURL && typeof options.baseURL === 'string'
? options.baseURL
: instanceBaseUrl;

return getUrl({
baseUrl: baseUrl as string,
path: options.path,
// let `paramsSerializer()` handle query params if it exists
query: !options.paramsSerializer ? options.query : undefined,
Expand All @@ -137,6 +144,7 @@ export const buildUrl: Client['buildUrl'] = (options) =>
: createQuerySerializer(options.querySerializer),
url: options.url,
});
};

export const mergeConfigs = (a: Config, b: Config): Config => {
const config = { ...a, ...b };
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const createClient = (config: Config = {}): Client => {
const { auth, ...optsWithoutAuth } = opts;
const response = await _axios({
...optsWithoutAuth,
baseURL: opts.baseURL as string,
baseURL: '', // the baseURL is already included in `url`
data: getValidRequestBody(opts),
headers: opts.headers as RawAxiosRequestHeaders,
// let `paramsSerializer()` handle query params if it exists
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ type BuildUrlFn = <
url: string;
},
>(
options: Pick<TData, 'url'> & Omit<Options<TData>, 'axios'>,
options: Pick<TData, 'url'> & Options<TData>,
) => string;

export type Client = CoreClient<
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,16 @@ export const setAuthParams = async ({
}
};

export const buildUrl: Client['buildUrl'] = (options) =>
getUrl({
baseUrl: options.baseURL as string,
export const buildUrl: Client['buildUrl'] = (options) => {
const instanceBaseUrl = options.axios?.defaults?.baseURL;

const baseUrl =
!!options.baseURL && typeof options.baseURL === 'string'
? options.baseURL
: instanceBaseUrl;

return getUrl({
baseUrl: baseUrl as string,
path: options.path,
// let `paramsSerializer()` handle query params if it exists
query: !options.paramsSerializer ? options.query : undefined,
Expand All @@ -137,6 +144,7 @@ export const buildUrl: Client['buildUrl'] = (options) =>
: createQuerySerializer(options.querySerializer),
url: options.url,
});
};

export const mergeConfigs = (a: Config, b: Config): Config => {
const config = { ...a, ...b };
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const createClient = (config: Config = {}): Client => {
const { auth, ...optsWithoutAuth } = opts;
const response = await _axios({
...optsWithoutAuth,
baseURL: opts.baseURL as string,
baseURL: '', // the baseURL is already included in `url`
data: getValidRequestBody(opts),
headers: opts.headers as RawAxiosRequestHeaders,
// let `paramsSerializer()` handle query params if it exists
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ type BuildUrlFn = <
url: string;
},
>(
options: Pick<TData, 'url'> & Omit<Options<TData>, 'axios'>,
options: Pick<TData, 'url'> & Options<TData>,
) => string;

export type Client = CoreClient<
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,16 @@ export const setAuthParams = async ({
}
};

export const buildUrl: Client['buildUrl'] = (options) =>
getUrl({
baseUrl: options.baseURL as string,
export const buildUrl: Client['buildUrl'] = (options) => {
const instanceBaseUrl = options.axios?.defaults?.baseURL;

const baseUrl =
!!options.baseURL && typeof options.baseURL === 'string'
? options.baseURL
: instanceBaseUrl;

return getUrl({
baseUrl: baseUrl as string,
path: options.path,
// let `paramsSerializer()` handle query params if it exists
query: !options.paramsSerializer ? options.query : undefined,
Expand All @@ -137,6 +144,7 @@ export const buildUrl: Client['buildUrl'] = (options) =>
: createQuerySerializer(options.querySerializer),
url: options.url,
});
};

export const mergeConfigs = (a: Config, b: Config): Config => {
const config = { ...a, ...b };
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const createClient = (config: Config = {}): Client => {
const { auth, ...optsWithoutAuth } = opts;
const response = await _axios({
...optsWithoutAuth,
baseURL: opts.baseURL as string,
baseURL: '', // the baseURL is already included in `url`
data: getValidRequestBody(opts),
headers: opts.headers as RawAxiosRequestHeaders,
// let `paramsSerializer()` handle query params if it exists
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ type BuildUrlFn = <
url: string;
},
>(
options: Pick<TData, 'url'> & Omit<Options<TData>, 'axios'>,
options: Pick<TData, 'url'> & Options<TData>,
) => string;

export type Client = CoreClient<
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,16 @@ export const setAuthParams = async ({
}
};

export const buildUrl: Client['buildUrl'] = (options) =>
getUrl({
baseUrl: options.baseURL as string,
export const buildUrl: Client['buildUrl'] = (options) => {
const instanceBaseUrl = options.axios?.defaults?.baseURL;

const baseUrl =
!!options.baseURL && typeof options.baseURL === 'string'
? options.baseURL
: instanceBaseUrl;

return getUrl({
baseUrl: baseUrl as string,
path: options.path,
// let `paramsSerializer()` handle query params if it exists
query: !options.paramsSerializer ? options.query : undefined,
Expand All @@ -137,6 +144,7 @@ export const buildUrl: Client['buildUrl'] = (options) =>
: createQuerySerializer(options.querySerializer),
url: options.url,
});
};

export const mergeConfigs = (a: Config, b: Config): Config => {
const config = { ...a, ...b };
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const createClient = (config: Config = {}): Client => {
const { auth, ...optsWithoutAuth } = opts;
const response = await _axios({
...optsWithoutAuth,
baseURL: opts.baseURL as string,
baseURL: '', // the baseURL is already included in `url`
data: getValidRequestBody(opts),
headers: opts.headers as RawAxiosRequestHeaders,
// let `paramsSerializer()` handle query params if it exists
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ type BuildUrlFn = <
url: string;
},
>(
options: Pick<TData, 'url'> & Omit<Options<TData>, 'axios'>,
options: Pick<TData, 'url'> & Options<TData>,
) => string;

export type Client = CoreClient<
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,16 @@ export const setAuthParams = async ({
}
};

export const buildUrl: Client['buildUrl'] = (options) =>
getUrl({
baseUrl: options.baseURL as string,
export const buildUrl: Client['buildUrl'] = (options) => {
const instanceBaseUrl = options.axios?.defaults?.baseURL;

const baseUrl =
!!options.baseURL && typeof options.baseURL === 'string'
? options.baseURL
: instanceBaseUrl;

return getUrl({
baseUrl: baseUrl as string,
path: options.path,
// let `paramsSerializer()` handle query params if it exists
query: !options.paramsSerializer ? options.query : undefined,
Expand All @@ -137,6 +144,7 @@ export const buildUrl: Client['buildUrl'] = (options) =>
: createQuerySerializer(options.querySerializer),
url: options.url,
});
};

export const mergeConfigs = (a: Config, b: Config): Config => {
const config = { ...a, ...b };
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const createClient = (config: Config = {}): Client => {
const { auth, ...optsWithoutAuth } = opts;
const response = await _axios({
...optsWithoutAuth,
baseURL: opts.baseURL as string,
baseURL: '', // the baseURL is already included in `url`
data: getValidRequestBody(opts),
headers: opts.headers as RawAxiosRequestHeaders,
// let `paramsSerializer()` handle query params if it exists
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ type BuildUrlFn = <
url: string;
},
>(
options: Pick<TData, 'url'> & Omit<Options<TData>, 'axios'>,
options: Pick<TData, 'url'> & Options<TData>,
) => string;

export type Client = CoreClient<
Expand Down
Loading
Loading