Skip to content

Conversation

marregui
Copy link
Contributor

@marregui marregui self-assigned this Sep 23, 2025
@cla-bot cla-bot bot added the cla-signed label Sep 23, 2025
Copy link

github-actions bot commented Sep 23, 2025

Test Results

  439 files  ±0    439 suites  ±0   4m 2s ⏱️ -13s
3 708 tests +6  3 705 ✅ +6  3 💤 ±0  0 ❌ ±0 
3 712 runs  +6  3 709 ✅ +6  3 💤 ±0  0 ❌ ±0 

Results for commit 21d08c1. ± Comparison against base commit 235bc93.

♻️ This comment has been updated with latest results.

@marregui marregui force-pushed the chore/34090-packet-size-matters-after-all branch from d27302e to 6baea60 Compare September 25, 2025 07:06
Copy link

github-actions bot commented Sep 25, 2025

Coverage Report

Overall Project 64.45%
Files changed 100%

File Coverage
MQTTMessageDecoder.java 92.09%

Copy link
Member

@caoccao caoccao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the majority of the changes are reformatting. What are the actual changes?

@marregui
Copy link
Contributor Author

It seems the majority of the changes are reformatting. What are the actual changes?

the changes come from https://github.com/hivemq/hivemq-community-edition/pull/583/files mainly MQTTMessageDecoder calculates max packet size prior to reading the message

@codepitbull codepitbull requested a review from a team September 26, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants