Add confirmation on exit

Common/Data/Text/Parsers.cpp

@@ -3,6 +3,7 @@
 #include <string>
 
 #include "Common/Data/Text/Parsers.h"
+#include "Common/Data/Text/I18n.h"
 #include "Common/StringUtils.h"
 
 // Not strictly a parser...
@@ -29,6 +30,19 @@ std::string NiceSizeFormat(uint64_t size) {
 	return std::string(buffer);
 }
 
+std::string NiceTimeFormat(int seconds) {
+	auto di = GetI18NCategory(I18NCat::DIALOG);
+	if (seconds < 60) {
+		return StringFromFormat("%d seconds", seconds);
+	} else if (seconds < 60 * 60) {
+		int minutes = seconds / 60;
+		return StringFromFormat("%d minutes", minutes);
+	} else {
+		int hours = seconds / 3600;
+		return StringFromFormat("%d hours", hours);
+	}
+}
+
 bool Version::ParseVersionString(std::string str) {
 	if (str.empty())
 		return false;

Common/Data/Text/Parsers.h

@@ -74,3 +74,7 @@ static bool TryParse(const std::string &str, N *const output) {
 void NiceSizeFormat(uint64_t size, char *out, size_t bufSize);
 
 std::string NiceSizeFormat(uint64_t size);
+
+// seconds, or minutes, or hours.
+// Uses I18N strings.
+std::string NiceTimeFormat(int seconds);

Core/Config.cpp

@@ -300,6 +300,7 @@ static const ConfigSetting generalSettings[] = {
 	ConfigSetting("RemoteTab", &g_Config.bRemoteTab, false, CfgFlag::DEFAULT),
 	ConfigSetting("RemoteISOSharedDir", &g_Config.sRemoteISOSharedDir, "", CfgFlag::DEFAULT),
 	ConfigSetting("RemoteISOShareType", &g_Config.iRemoteISOShareType, (int)RemoteISOShareType::RECENT, CfgFlag::DEFAULT),
+	ConfigSetting("AskForExitConfirmationAfterSeconds", &g_Config.iAskForExitConfirmationAfterSeconds, 60, CfgFlag::PER_GAME),
 
 #ifdef __ANDROID__
 	ConfigSetting("ScreenRotation", &g_Config.iScreenRotation, ROTATION_AUTO_HORIZONTAL),

Core/Config.h

@@ -137,6 +137,7 @@ struct Config {
 	bool bMemStickInserted;
 	int iMemStickSizeGB;
 	bool bLoadPlugins;
+	int iAskForExitConfirmationAfterSeconds;
 
 	int iScreenRotation;  // The rotation angle of the PPSSPP UI. Only supported on Android and possibly other mobile platforms.
 	int iInternalScreenRotation;  // The internal screen rotation angle. Useful for vertical SHMUPs and similar.

Core/Dialog/PSPSaveDialog.cpp

@@ -29,6 +29,7 @@
 #include "Core/Dialog/PSPSaveDialog.h"
 #include "Core/FileSystems/MetaFileSystem.h"
 #include "Core/Util/PPGeDraw.h"
+#include "Common/TimeUtil.h"
 #include "Core/HLE/sceCtrl.h"
 #include "Core/HLE/sceUtility.h"
 #include "Core/HLE/ErrorCodes.h"
@@ -38,6 +39,20 @@
 #include "Core/Reporting.h"
 #include "Core/SaveState.h"
 
+static double g_lastSaveTime = -1.0;
+
+void ResetSecondsSinceLastGameSave() {
+	g_lastSaveTime = time_now_d();
+}
+
+double SecondsSinceLastGameSave() {
+	if (g_lastSaveTime < 0) {
+		return -1.0;
+	} else {
+		return time_now_d() - g_lastSaveTime;
+	}
+}
+
 const static float FONT_SCALE = 0.55f;
 
 // These are rough, it seems to take at least 100ms or so to init, and shutdown depends on threads.
@@ -85,8 +100,7 @@ PSPSaveDialog::~PSPSaveDialog() {
 	JoinIOThread();
 }
 
-int PSPSaveDialog::Init(int paramAddr)
-{
+int PSPSaveDialog::Init(int paramAddr) {
 	// Ignore if already running
 	if (GetStatus() != SCE_UTILITY_STATUS_NONE) {
 		ERROR_LOG_REPORT(Log::sceUtility, "A save request is already running, not starting a new one");
@@ -1068,6 +1082,7 @@ void PSPSaveDialog::ExecuteIOAction() {
 		result = param.Load(param.GetPspParam(), GetSelectedSaveDirName(), currentSelectedSave);
 		if (result == 0) {
 			display = DS_LOAD_DONE;
+			g_lastSaveTime = time_now_d();
 		} else {
 			display = DS_LOAD_FAILED;
 		}
@@ -1076,6 +1091,7 @@ void PSPSaveDialog::ExecuteIOAction() {
 		SaveState::NotifySaveData();
 		if (param.Save(param.GetPspParam(), GetSelectedSaveDirName()) == 0) {
 			display = DS_SAVE_DONE;
+			g_lastSaveTime = time_now_d();
 		} else {
 			display = DS_SAVE_FAILED;
 		}

Core/Dialog/PSPSaveDialog.h

@@ -104,6 +104,8 @@ class PSPSaveDialog : public PSPDialog {
 
 	std::thread *ioThread = nullptr;
 	std::mutex paramLock;
-	volatile SaveIOStatus ioThreadStatus;
+	volatile SaveIOStatus ioThreadStatus = SAVEIO_NONE;
 };
 
+void ResetSecondsSinceLastGameSave();
+double SecondsSinceLastGameSave();

Core/HLE/sceUtility.cpp

@@ -227,6 +227,8 @@ void __UtilityInit() {
 	SavedataParam::Init();
 	currentlyLoadedModules.clear();
 	volatileUnlockEvent = CoreTiming::RegisterEvent("UtilityVolatileUnlock", UtilityVolatileUnlock);
+
+	ResetSecondsSinceLastGameSave();
 }
 
 void __UtilityDoState(PointerWrap &p) {

Core/SaveState.cpp

@@ -60,8 +60,10 @@
 // Slot number is visual only, -2 will display special message
 constexpr int LOAD_UNDO_SLOT = -2;
 
-namespace SaveState
-{
+namespace SaveState {
+
+double g_lastSaveTime = -1.0;
+
 	struct SaveStart
 	{
 		void DoState(PointerWrap &p);
@@ -76,13 +78,10 @@ namespace SaveState
 		SAVESTATE_SAVE_SCREENSHOT,
 	};
 
-	struct Operation
-	{
+	struct Operation {
 		// The slot number is for visual purposes only. Set to -1 for operations where we don't display a message for example.
 		Operation(OperationType t, const Path &f, int slot_, Callback cb, void *cbUserData_)
-			: type(t), filename(f), callback(cb), slot(slot_), cbUserData(cbUserData_)
-		{
-		}
+			: type(t), filename(f), callback(cb), slot(slot_), cbUserData(cbUserData_) {}
 
 		OperationType type;
 		Path filename;
@@ -1005,6 +1004,7 @@ namespace SaveState
 						}
 					}
 #endif
+					g_lastSaveTime = time_now_d();
 				} else if (result == CChunkFileReader::ERROR_BROKEN_STATE) {
 					HandleLoadFailure(false);
 					callbackMessage = std::string(i18nLoadFailure) + ": " + errorString;
@@ -1040,6 +1040,7 @@ namespace SaveState
 						}
 					}
 #endif
+					g_lastSaveTime = time_now_d();
 				} else if (result == CChunkFileReader::ERROR_BROKEN_STATE) {
 					// TODO: What else might we want to do here? This should be very unusual.
 					callbackMessage = i18nSaveFailure;
@@ -1155,11 +1156,21 @@ namespace SaveState
 		saveDataGeneration = 0;
 		lastSaveDataGeneration = 0;
 		saveStateInitialGitVersion.clear();
+
+		g_lastSaveTime = time_now_d();
 	}
 
 	void Shutdown()
 	{
 		std::lock_guard<std::mutex> guard(mutex);
 		rewindStates.Clear();
 	}
+
+	double SecondsSinceLastSavestate() {
+		if (g_lastSaveTime < 0) {
+			return -1.0;
+		} else {
+			return time_now_d() - g_lastSaveTime;
+		}
+	}
 }

Core/SaveState.h

@@ -25,8 +25,7 @@
 #include "Common/File/Path.h"
 #include "Common/Serialize/Serializer.h"
 
-namespace SaveState
-{
+namespace SaveState {
 	enum class Status {
 		FAILURE,
 		WARNING,
@@ -111,4 +110,7 @@ namespace SaveState
 
 	// Cleanup by triggering a restart if needed.
 	void Cleanup();
-};
+
+	// Returns the time since last save. -1 if N/A.
+	double SecondsSinceLastSavestate();
+}  // namespace SaveState

UI/GameSettingsScreen.cpp

@@ -1300,6 +1300,9 @@ void GameSettingsScreen::CreateSystemSettings(UI::ViewGroup *systemSettings) {
 
 	systemSettings->Add(new ItemHeader(sy->T("General")));
 
+	PopupSliderChoice *exitConfirmation = systemSettings->Add(new PopupSliderChoice(&g_Config.iAskForExitConfirmationAfterSeconds, 0, 1200, 60, sy->T("Ask for exit confirmation after seconds"), screenManager(), "s"));
+	exitConfirmation->SetZeroLabel(sy->T("Off"));
+
 #if PPSSPP_PLATFORM(ANDROID)
 	if (System_GetPropertyInt(SYSPROP_DEVICE_TYPE) == DEVICE_TYPE_MOBILE) {
 		auto co = GetI18NCategory(I18NCat::CONTROLS);

UI/PauseScreen.cpp

@@ -26,6 +26,7 @@
 #include "Common/GPU/thin3d.h"
 
 #include "Common/Data/Text/I18n.h"
+#include "Common/Data/Text/Parsers.h"
 #include "Common/StringUtils.h"
 #include "Common/System/OSD.h"
 #include "Common/System/Request.h"
@@ -34,6 +35,7 @@
 
 #include "Core/KeyMap.h"
 #include "Core/Reporting.h"
+#include "Core/Dialog/PSPSaveDialog.h"
 #include "Core/SaveState.h"
 #include "Core/System.h"
 #include "Core/Core.h"
@@ -516,9 +518,9 @@ void GamePauseScreen::CreateViews() {
 	rightColumnItems->Add(new Spacer(20.0));
 	if (g_Config.bPauseMenuExitsEmulator) {
 		auto mm = GetI18NCategory(I18NCat::MAINMENU);
-		rightColumnItems->Add(new Choice(mm->T("Exit")))->OnClick.Handle(this, &GamePauseScreen::OnExitToMenu);
+		rightColumnItems->Add(new Choice(mm->T("Exit")))->OnClick.Handle(this, &GamePauseScreen::OnExit);
 	} else {
-		rightColumnItems->Add(new Choice(pa->T("Exit to menu")))->OnClick.Handle(this, &GamePauseScreen::OnExitToMenu);
+		rightColumnItems->Add(new Choice(pa->T("Exit to menu")))->OnClick.Handle(this, &GamePauseScreen::OnExit);
 	}
 
 	middleColumn->SetSpacing(20.0f);
@@ -578,12 +580,34 @@ UI::EventReturn GamePauseScreen::OnScreenshotClicked(UI::EventParams &e) {
 	return UI::EVENT_DONE;
 }
 
-UI::EventReturn GamePauseScreen::OnExitToMenu(UI::EventParams &e) {
+int GetUnsavedProgressSeconds() {
+	const double timeSinceSaveState = SaveState::SecondsSinceLastSavestate();
+	const double timeSinceGameSave = SecondsSinceLastGameSave();
+
+	return (int)std::min(timeSinceSaveState, timeSinceGameSave);
+}
+
+UI::EventReturn GamePauseScreen::OnExit(UI::EventParams &e) {
+	std::string confirmMessage;
+
+	int unsavedSeconds = GetUnsavedProgressSeconds();
+
 	// If RAIntegration has dirty info, ask for confirmation.
 	if (Achievements::RAIntegrationDirty()) {
 		auto ac = GetI18NCategory(I18NCat::ACHIEVEMENTS);
+		confirmMessage = ac->T("You have unsaved RAIntegration changes. Exit?");
+	} else if (g_Config.iAskForExitConfirmationAfterSeconds > 0 && unsavedSeconds > g_Config.iAskForExitConfirmationAfterSeconds) {
+		auto di = GetI18NCategory(I18NCat::DIALOG);
+		std::string dlgMsg = ApplySafeSubstitutions(di->T("You haven't saved your progress for %1."), NiceTimeFormat((int)unsavedSeconds));
+		dlgMsg += '\n';
+		dlgMsg += '\n';
+		dlgMsg += di->T("Are you sure you want to exit? All unsaved progress will be lost.");
+		confirmMessage = dlgMsg;
+	}
+
+	if (!confirmMessage.empty()) {
 		auto di = GetI18NCategory(I18NCat::DIALOG);
-		screenManager()->push(new PromptScreen(gamePath_, ac->T("You have unsaved RAIntegration changes. Exit?"), di->T("Yes"), di->T("No"), [=](bool result) {
+		screenManager()->push(new PromptScreen(gamePath_, confirmMessage, di->T("Yes"), di->T("No"), [=](bool result) {
 			if (result) {
 				if (g_Config.bPauseMenuExitsEmulator) {
 					System_ExitApp();

UI/PauseScreen.h

@@ -45,7 +45,7 @@ class GamePauseScreen : public UIDialogScreenWithGameBackground {
 	void CreateSavestateControls(UI::LinearLayout *viewGroup, bool vertical);
 
 	UI::EventReturn OnGameSettings(UI::EventParams &e);
-	UI::EventReturn OnExitToMenu(UI::EventParams &e);
+	UI::EventReturn OnExit(UI::EventParams &e);
 	UI::EventReturn OnReportFeedback(UI::EventParams &e);
 
 	UI::EventReturn OnRewind(UI::EventParams &e);

Windows/MainWindow.cpp

@@ -37,6 +37,7 @@
 #include "Common/TimeUtil.h"
 #include "Common/StringUtils.h"
 #include "Common/Data/Text/I18n.h"
+#include "Common/Data/Text/Parsers.h"
 #include "Common/Input/InputState.h"
 #include "Common/Input/KeyCodes.h"
 #include "Common/Thread/ThreadUtil.h"
@@ -85,6 +86,8 @@
 #include "GPU/GPUCommon.h"
 #include "UI/OnScreenDisplay.h"
 #include "UI/GameSettingsScreen.h"
+#include "Core/SaveState.h"
+#include "Core/Dialog/PSPSaveDialog.h"
 
 #define MOUSEEVENTF_FROMTOUCH_NOPEN 0xFF515780 //http://msdn.microsoft.com/en-us/library/windows/desktop/ms703320(v=vs.85).aspx
 #define MOUSEEVENTF_MASK_PLUS_PENTOUCH 0xFFFFFF80
@@ -813,6 +816,29 @@ namespace MainWindow
 		};
 	}
 
+	bool ConfirmExit(HWND hWnd) {
+		GlobalUIState state = GetUIState();
+		if (state != UISTATE_MENU && state != UISTATE_EXIT && g_Config.iAskForExitConfirmationAfterSeconds > 0) {
+			const double timeSinceSaveState = SaveState::SecondsSinceLastSavestate();
+			const double timeSinceGameSave = SecondsSinceLastGameSave();
+
+			const double minTime = std::min(timeSinceSaveState, timeSinceGameSave);
+			if (minTime > g_Config.iAskForExitConfirmationAfterSeconds) {
+				auto di = GetI18NCategory(I18NCat::DIALOG);
+				auto mm = GetI18NCategory(I18NCat::MAINMENU);
+				std::string dlgMsg = ApplySafeSubstitutions(di->T("You haven't saved your progress for %1."), NiceTimeFormat((int)minTime));
+				dlgMsg += '\n';
+				dlgMsg += '\n';
+				dlgMsg += di->T("Are you sure you want to exit? All unsaved progress will be lost.");
+
+				if (IDNO == MessageBox(hWnd, ConvertUTF8ToWString(dlgMsg).c_str(), ConvertUTF8ToWString(mm->T("Exit")).c_str(), MB_YESNO | MB_ICONQUESTION)) {
+					return false;
+				}
+			}
+		}
+		return true;
+	}
+
 	LRESULT CALLBACK WndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)	{
 		LRESULT darkResult = 0;
 		if (UAHDarkModeWndProc(hWnd, message, wParam, lParam, &darkResult)) {
@@ -1090,12 +1116,17 @@ namespace MainWindow
 			break;
 
 		case WM_CLOSE:
+		{
+			if (ConfirmExit(hWnd)) {
+				DestroyWindow(hWnd);
+			}
+			return 0;
+		}
+
+		case WM_DESTROY:
 			InputDevice::StopPolling();
 			MainThread_Stop();
 			WindowsRawInput::Shutdown();
-			return DefWindowProc(hWnd,message,wParam,lParam);
-
-		case WM_DESTROY:
 			KillTimer(hWnd, TIMER_CURSORUPDATE);
 			KillTimer(hWnd, TIMER_CURSORMOVEUPDATE);
 			// Main window is gone, this tells the message loop to exit.

Windows/MainWindow.h

@@ -82,6 +82,7 @@ namespace MainWindow
 	void SetWindowSize(int zoom);
 	void RunCallbackInWndProc(void (*callback)(void *window, void *userdata), void *userdata);
 	void SetKeepScreenBright(bool keepBright);
+	bool ConfirmExit(HWND hWnd);
 }
 
 #endif

Windows/MainWindowMenu.cpp

@@ -443,7 +443,7 @@ namespace MainWindow {
 			PostMessage(MainWindow::GetHWND(), WM_USER_RESTART_EMUTHREAD, 0, 0);
 		} else {
 			g_Config.bRestartRequired = true;
-			PostMessage(MainWindow::GetHWND(), WM_CLOSE, 0, 0);
+			DestroyWindow(MainWindow::GetHWND());
 		}
 	}
 
@@ -755,7 +755,9 @@ namespace MainWindow {
 		case ID_OPTIONS_FRAMESKIPTYPE_PRCNT:    setFrameSkippingType(FRAMESKIPTYPE_PRCNT); break;
 
 		case ID_FILE_EXIT:
-			PostMessage(hWnd, WM_CLOSE, 0, 0);
+			if (MainWindow::ConfirmExit(hWnd)) {
+				DestroyWindow(hWnd);
+			}
 			break;
 
 		case ID_DEBUG_BREAKONLOAD: