-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Bump dill to 0.4.0 #7763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dill to 0.4.0 #7763
Conversation
….9 support (#2) * Initial plan * Extract DILL_VERSION check to private function and add 0.3.9 support Co-authored-by: Bomme <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Have you tried to run
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Hi @lhoestq! Yes, I did. It's not really FYI: I also tested it with |
The NameError is fixed in your PR since it defines the right But I'm less sure about the AssertionError that may be related to deterministic hashing or ipython/shell function hashing. We would need to solve these EDIT: ah actually it does ! cool ! let me update the branch and re-run the CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
could you also add the same for 0.4.0 before we merge ?
the CI failures are unrelated to this PR
This bumps
dill
to 0.3.9 and closes #7510It turns out the only thing required to make the tests pass was to extend the version checks to include 0.3.9.