-
Notifications
You must be signed in to change notification settings - Fork 791
Conditionally allow request redirection with environment variable #3305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conditionally allow request redirection with environment variable #3305
Conversation
4389869
to
5f2febd
Compare
This has been tested successfully behind a Cisco Umbrella firewall inserting redirects to opendns.com, can someone please review? |
5f2febd
to
47f0cc4
Compare
47f0cc4
to
281d675
Compare
Hi @raka-gunarto,
|
Yeah we did that in the end, but can it not silently fail as well? I was scratching my head for hours, because it just thinks it reached a CDN and then silently dies because it doesn't see what it expects to see. |
@raka-gunarto could you open an issue with a minimal script that reproduces the issue with the full log output with |
@hanouticelina I've just tried to reproduce and now it just fails outright, I think previously it grabbed the metadata but cisco umbrella wasn't consistent in redirecting and allowing some things through resulting partial downloads of models. I suppose I'll just close this PR since this really would affect a small subset of people. Maybe include the returned response on a failed request for metadata (so at least the user can see if it was something intercepting their requests, etc. I've included logs and hf env output anyway below.
|
Sometimes you're behind a corporate firewall like Cisco Umbrella which does funny business like adding redirections. Add redirect domain allowlist with environment variable.
Example use: